git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org, Denton Liu <liu.denton@gmail.com>
Subject: Re: [PATCH v3 0/3] Accommodate for pu having been renamed to seen
Date: Tue, 30 Jun 2020 09:03:14 -0700	[thread overview]
Message-ID: <xmqqpn9gee2l.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.2006291606060.56@tvgsbejvaqbjf.bet> (Johannes Schindelin's message of "Mon, 29 Jun 2020 16:07:14 +0200 (CEST)")

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

>> You could have just told me that the fixup queued on 'seen' looks
>> good to you and squash it in the first step instead to save one
>> roundtrip, but replacing with a new set of three patches is not so
>> bad, either ;-)
>
> To be honest, the GitGitGadget-based workflow makes it quicker for me to
> just submit a new iteration.

I do not mind seeing a new iteration that gives easier time for
others to comment on the version that is closer to the final than
the previous round.  The offer was only for contributors who find
it easier to just say "yeah, I am happy with that change" than
submitting a new round.

> In fact, I did not even see your fixup until I read your mail.

This I actually would mind a bit more.  The reason why I publish
'seen' is to make it easier for authors of individual topics how
their work would play with other topics in flight, and it diminishes
the value of it if contributors do not pay attention to what is
queued there.  I expect contributors to fetch and look at what is
queued in origin/seen.

There may be evil merges that reveal subtle interactions between
topics, some of which may involve the topic an author may care
about.  There may be fixups for problems that were not found during
review but only found during the integration process.  I try to
communicate these back on the list when possible, but the thing is,
a day does not have sufficient number of minutes for me to always do
so.

Thanks.

  reply	other threads:[~2020-06-30 16:03 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-23 15:04 [PATCH 0/3] Accommodate for pu having been renamed to seen Johannes Schindelin via GitGitGadget
2020-06-23 15:04 ` [PATCH 1/3] docs: adjust for the recent rename of `pu` to `seen` Johannes Schindelin via GitGitGadget
2020-06-23 15:31   ` Đoàn Trần Công Danh
2020-06-23 19:31     ` Junio C Hamano
2020-06-23 21:32       ` Johannes Schindelin
2020-06-24  0:46       ` Đoàn Trần Công Danh
2020-06-23 15:04 ` [PATCH 2/3] docs: adjust the technical overview for the rename `pu` -> `seen` Johannes Schindelin via GitGitGadget
2020-06-23 15:04 ` [PATCH 3/3] tests: reference `seen` wherever `pu` was referenced Johannes Schindelin via GitGitGadget
2020-06-24 14:48 ` [PATCH v2 0/3] Accommodate for pu having been renamed to seen Johannes Schindelin via GitGitGadget
2020-06-24 14:48   ` [PATCH v2 1/3] docs: adjust for the recent rename of `pu` to `seen` Johannes Schindelin via GitGitGadget
2020-06-24 15:07     ` Denton Liu
2020-06-24 14:48   ` [PATCH v2 2/3] docs: adjust the technical overview for the rename `pu` -> `seen` Johannes Schindelin via GitGitGadget
2020-06-24 14:48   ` [PATCH v2 3/3] tests: reference `seen` wherever `pu` was referenced Johannes Schindelin via GitGitGadget
2020-06-24 15:24   ` [PATCH v2 0/3] Accommodate for pu having been renamed to seen Denton Liu
2020-06-24 15:42     ` Junio C Hamano
2020-06-29 13:40       ` Johannes Schindelin
2020-06-24 15:38   ` Junio C Hamano
2020-06-24 17:05     ` Junio C Hamano
2020-06-24 17:24       ` Denton Liu
2020-06-24 17:38         ` Junio C Hamano
2020-06-29 14:05       ` Johannes Schindelin
2020-06-25 12:18   ` [PATCH v3 " Johannes Schindelin via GitGitGadget
2020-06-25 12:18     ` [PATCH v3 1/3] docs: adjust for the recent rename of `pu` to `seen` Johannes Schindelin via GitGitGadget
2020-06-25 12:18     ` [PATCH v3 2/3] docs: adjust the technical overview for the rename `pu` -> `seen` Johannes Schindelin via GitGitGadget
2020-06-25 12:18     ` [PATCH v3 3/3] tests: reference `seen` wherever `pu` was referenced Johannes Schindelin via GitGitGadget
2020-06-25 16:22     ` [PATCH v3 0/3] Accommodate for pu having been renamed to seen Junio C Hamano
2020-06-29 14:07       ` Johannes Schindelin
2020-06-30 16:03         ` Junio C Hamano [this message]
2020-07-01 10:42           ` Johannes Schindelin
2020-06-26  9:06     ` Update ProGit for pu -> seen change? (was Re: [PATCH v3 0/3] Accommodate for pu having been renamed to seen) Kaartic Sivaraam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqpn9gee2l.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=liu.denton@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).