From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Đoàn Trần Công Danh" <congdanhqx@gmail.com>,
"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH 1/3] docs: adjust for the recent rename of `pu` to `seen`
Date: Tue, 23 Jun 2020 23:32:14 +0200 (CEST) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.2006232330550.54@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <xmqq5zbhd1em.fsf@gitster.c.googlers.com>
[-- Attachment #1: Type: text/plain, Size: 2958 bytes --]
Hi Junio & Danh,
On Tue, 23 Jun 2020, Junio C Hamano wrote:
> Đoàn Trần Công Danh <congdanhqx@gmail.com> writes:
>
> > On 2020-06-23 15:04:13+0000, Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com> wrote:
> >> diff --git a/Documentation/git-ls-remote.txt b/Documentation/git-ls-remote.txt
> >> index 0a5c8b7d493..492e573856f 100644
> >> --- a/Documentation/git-ls-remote.txt
> >> +++ b/Documentation/git-ls-remote.txt
> >> @@ -101,9 +101,9 @@ f25a265a342aed6041ab0cc484224d9ca54b6f41 refs/tags/v0.99.1
> >> 7ceca275d047c90c0c7d5afb13ab97efdf51bd6e refs/tags/v0.99.3
> >> c5db5456ae3b0873fc659c19fafdde22313cc441 refs/tags/v0.99.2
> >> 0918385dbd9656cab0d1d81ba7453d49bbc16250 refs/tags/junio-gpg-pub
> >> -$ git ls-remote http://www.kernel.org/pub/scm/git/git.git master pu rc
> >> +$ git ls-remote http://www.kernel.org/pub/scm/git/git.git master seen rc
> >
> > rc is not with us anymore.
> >
> > Should we replace it with next, too?
>
> I do not think so. I think we never had 'rc'.
Indeed, and the context given in the patch demonstrates that no `rc` is
shown, so I assumed the same things as Junio explained here:
> I think what the above example is demonstrating is this.
>
> SYNOPSIS calls the last command line arguments <refs>; they are
> actually mere patterns (which is how these command line
> arguments are described in the documentation). It is *not* an
> error if no refs match a particular pattern.
>
> And because we have no refs that match the pattern "rc", we only see
> "master" and "pu" (now "seen") from the command.
Precisely.
> I see a couple of possible improvements here:
>
> - The "<refs>...::" documentation should explain what kind of
> pattern match is performed here. I recall these originally were
> just tail matches, but the rule might have been made more
> flexible over time.
>
> - The example should first explain the setting. The first sample
> depends on the current (./.) repository having these tags or it
> would not work (showing the sample upfront and explaining the
> outcome shown in the sample would work well in this case,
> e.g. "we can see that in the current repository, there are tags
> X, Y and Z"). The second one at least needs to say two things:
> the sample repository does not have a branch called 'rc' and that
> is why it is not shown, and it is not an error for patterns to
> produce no match.
Those sound like wonderful #leftoverbits to me.
Thank you,
Dscho
>
> Thanks.
>
> >
> >> 5fe978a5381f1fbad26a80e682ddd2a401966740 refs/heads/master
> >> -c781a84b5204fb294c9ccc79f8b3baceeb32c061 refs/heads/pu
> >> +c781a84b5204fb294c9ccc79f8b3baceeb32c061 refs/heads/seen
> >> $ git remote add korg http://www.kernel.org/pub/scm/git/git.git
> >> $ git ls-remote --tags korg v\*
> >> d6602ec5194c87b0fc87103ca4d67251c76f233a refs/tags/v0.99
>
next prev parent reply other threads:[~2020-06-23 21:32 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-23 15:04 [PATCH 0/3] Accommodate for pu having been renamed to seen Johannes Schindelin via GitGitGadget
2020-06-23 15:04 ` [PATCH 1/3] docs: adjust for the recent rename of `pu` to `seen` Johannes Schindelin via GitGitGadget
2020-06-23 15:31 ` Đoàn Trần Công Danh
2020-06-23 19:31 ` Junio C Hamano
2020-06-23 21:32 ` Johannes Schindelin [this message]
2020-06-24 0:46 ` Đoàn Trần Công Danh
2020-06-23 15:04 ` [PATCH 2/3] docs: adjust the technical overview for the rename `pu` -> `seen` Johannes Schindelin via GitGitGadget
2020-06-23 15:04 ` [PATCH 3/3] tests: reference `seen` wherever `pu` was referenced Johannes Schindelin via GitGitGadget
2020-06-24 14:48 ` [PATCH v2 0/3] Accommodate for pu having been renamed to seen Johannes Schindelin via GitGitGadget
2020-06-24 14:48 ` [PATCH v2 1/3] docs: adjust for the recent rename of `pu` to `seen` Johannes Schindelin via GitGitGadget
2020-06-24 15:07 ` Denton Liu
2020-06-24 14:48 ` [PATCH v2 2/3] docs: adjust the technical overview for the rename `pu` -> `seen` Johannes Schindelin via GitGitGadget
2020-06-24 14:48 ` [PATCH v2 3/3] tests: reference `seen` wherever `pu` was referenced Johannes Schindelin via GitGitGadget
2020-06-24 15:24 ` [PATCH v2 0/3] Accommodate for pu having been renamed to seen Denton Liu
2020-06-24 15:42 ` Junio C Hamano
2020-06-29 13:40 ` Johannes Schindelin
2020-06-24 15:38 ` Junio C Hamano
2020-06-24 17:05 ` Junio C Hamano
2020-06-24 17:24 ` Denton Liu
2020-06-24 17:38 ` Junio C Hamano
2020-06-29 14:05 ` Johannes Schindelin
2020-06-25 12:18 ` [PATCH v3 " Johannes Schindelin via GitGitGadget
2020-06-25 12:18 ` [PATCH v3 1/3] docs: adjust for the recent rename of `pu` to `seen` Johannes Schindelin via GitGitGadget
2020-06-25 12:18 ` [PATCH v3 2/3] docs: adjust the technical overview for the rename `pu` -> `seen` Johannes Schindelin via GitGitGadget
2020-06-25 12:18 ` [PATCH v3 3/3] tests: reference `seen` wherever `pu` was referenced Johannes Schindelin via GitGitGadget
2020-06-25 16:22 ` [PATCH v3 0/3] Accommodate for pu having been renamed to seen Junio C Hamano
2020-06-29 14:07 ` Johannes Schindelin
2020-06-30 16:03 ` Junio C Hamano
2020-07-01 10:42 ` Johannes Schindelin
2020-06-26 9:06 ` Update ProGit for pu -> seen change? (was Re: [PATCH v3 0/3] Accommodate for pu having been renamed to seen) Kaartic Sivaraam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.2006232330550.54@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=congdanhqx@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).