From: Junio C Hamano <gitster@pobox.com>
To: Johannes Sixt <j6t@kdbg.org>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Git Mailing List" <git@vger.kernel.org>
Subject: Re: [PATCH ab/fsck-unexpected-type] t1450-fsck: exec-bit is not needed to make loose object writable
Date: Thu, 13 Jan 2022 15:04:58 -0800 [thread overview]
Message-ID: <xmqqpmovfd9h.fsf@gitster.g> (raw)
In-Reply-To: 529d99f3-13c8-ffc1-dd4c-3fc70330262a@kdbg.org
Johannes Sixt <j6t@kdbg.org> writes:
> A test case wants to append stuff to a loose object file to ensure
> that this kind of corruption is detected. To make a read-only loose
> object file writable with chmod, it is not necessary to also make
> it executable. Replace the bitmask 755 with the instruction +w to
> request only the write bit and to also heed the umask. And get rid
> of a POSIXPERM prerequisite, which is unnecessary for the test.
>
> Signed-off-by: Johannes Sixt <j6t@kdbg.org>
> ---
> I happened to notice this by chance when I built on Windows today.
Thanks. Looks quite sensible.
>
> t/t1450-fsck.sh | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/t/t1450-fsck.sh b/t/t1450-fsck.sh
> index 6337236fd8..de50c0ea01 100755
> --- a/t/t1450-fsck.sh
> +++ b/t/t1450-fsck.sh
> @@ -94,13 +94,13 @@ test_expect_success 'object with hash and type mismatch' '
> )
> '
>
> -test_expect_success POSIXPERM 'zlib corrupt loose object output ' '
> +test_expect_success 'zlib corrupt loose object output ' '
> git init --bare corrupt-loose-output &&
> (
> cd corrupt-loose-output &&
> oid=$(git hash-object -w --stdin --literally </dev/null) &&
> oidf=objects/$(test_oid_to_path "$oid") &&
> - chmod 755 $oidf &&
> + chmod +w $oidf &&
> echo extra garbage >>$oidf &&
>
> cat >expect.error <<-EOF &&
prev parent reply other threads:[~2022-01-13 23:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-13 20:28 [PATCH ab/fsck-unexpected-type] t1450-fsck: exec-bit is not needed to make loose object writable Johannes Sixt
2022-01-13 23:04 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpmovfd9h.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).