* [PATCH ab/fsck-unexpected-type] t1450-fsck: exec-bit is not needed to make loose object writable
@ 2022-01-13 20:28 Johannes Sixt
2022-01-13 23:04 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: Johannes Sixt @ 2022-01-13 20:28 UTC (permalink / raw)
To: Ævar Arnfjörð Bjarmason; +Cc: Git Mailing List, Junio C Hamano
A test case wants to append stuff to a loose object file to ensure
that this kind of corruption is detected. To make a read-only loose
object file writable with chmod, it is not necessary to also make
it executable. Replace the bitmask 755 with the instruction +w to
request only the write bit and to also heed the umask. And get rid
of a POSIXPERM prerequisite, which is unnecessary for the test.
Signed-off-by: Johannes Sixt <j6t@kdbg.org>
---
I happened to notice this by chance when I built on Windows today.
t/t1450-fsck.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/t1450-fsck.sh b/t/t1450-fsck.sh
index 6337236fd8..de50c0ea01 100755
--- a/t/t1450-fsck.sh
+++ b/t/t1450-fsck.sh
@@ -94,13 +94,13 @@ test_expect_success 'object with hash and type mismatch' '
)
'
-test_expect_success POSIXPERM 'zlib corrupt loose object output ' '
+test_expect_success 'zlib corrupt loose object output ' '
git init --bare corrupt-loose-output &&
(
cd corrupt-loose-output &&
oid=$(git hash-object -w --stdin --literally </dev/null) &&
oidf=objects/$(test_oid_to_path "$oid") &&
- chmod 755 $oidf &&
+ chmod +w $oidf &&
echo extra garbage >>$oidf &&
cat >expect.error <<-EOF &&
--
2.34.1.141.g867d0e9267
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH ab/fsck-unexpected-type] t1450-fsck: exec-bit is not needed to make loose object writable
2022-01-13 20:28 [PATCH ab/fsck-unexpected-type] t1450-fsck: exec-bit is not needed to make loose object writable Johannes Sixt
@ 2022-01-13 23:04 ` Junio C Hamano
0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2022-01-13 23:04 UTC (permalink / raw)
To: Johannes Sixt; +Cc: Ævar Arnfjörð Bjarmason, Git Mailing List
Johannes Sixt <j6t@kdbg.org> writes:
> A test case wants to append stuff to a loose object file to ensure
> that this kind of corruption is detected. To make a read-only loose
> object file writable with chmod, it is not necessary to also make
> it executable. Replace the bitmask 755 with the instruction +w to
> request only the write bit and to also heed the umask. And get rid
> of a POSIXPERM prerequisite, which is unnecessary for the test.
>
> Signed-off-by: Johannes Sixt <j6t@kdbg.org>
> ---
> I happened to notice this by chance when I built on Windows today.
Thanks. Looks quite sensible.
>
> t/t1450-fsck.sh | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/t/t1450-fsck.sh b/t/t1450-fsck.sh
> index 6337236fd8..de50c0ea01 100755
> --- a/t/t1450-fsck.sh
> +++ b/t/t1450-fsck.sh
> @@ -94,13 +94,13 @@ test_expect_success 'object with hash and type mismatch' '
> )
> '
>
> -test_expect_success POSIXPERM 'zlib corrupt loose object output ' '
> +test_expect_success 'zlib corrupt loose object output ' '
> git init --bare corrupt-loose-output &&
> (
> cd corrupt-loose-output &&
> oid=$(git hash-object -w --stdin --literally </dev/null) &&
> oidf=objects/$(test_oid_to_path "$oid") &&
> - chmod 755 $oidf &&
> + chmod +w $oidf &&
> echo extra garbage >>$oidf &&
>
> cat >expect.error <<-EOF &&
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-13 23:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-13 20:28 [PATCH ab/fsck-unexpected-type] t1450-fsck: exec-bit is not needed to make loose object writable Johannes Sixt
2022-01-13 23:04 ` Junio C Hamano
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).