From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Thomas Gummerer <t.gummerer@gmail.com>,
git@vger.kernel.org, Taylor Blau <me@ttaylorr.com>
Subject: Re: [PATCH] fetch --prune: exit with error if pruning fails
Date: Fri, 28 Jan 2022 10:14:43 -0800 [thread overview]
Message-ID: <xmqqpmobwwvg.fsf@gitster.g> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.2201281110050.347@tvgsbejvaqbjf.bet> (Johannes Schindelin's message of "Fri, 28 Jan 2022 11:13:56 +0100 (CET)")
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> I am not so sure. When pruning failed, there may very well be directories
> or files in the way of fetching the refs as desired. And it might be even
> worse if pruning failed _without_ the fetch failing afterwards: the user
> specifically asked for stale refs to be cleaned up, the command succeeded,
> but did not do what the user asked for.
>
> Maybe Thomas has an even stronger argument in favor of erroring out. In
> any case, I don't think that `--prune` should be a "best effort, otherwise
> just shrug" option. If we wanted that, we could introduce
> `--prune-best-effort` or some such...
I am not opposed to reporting an error by exiting with non-zero exit
code. I never said it should be best effort, and doing the "fetch" part
after a failed prune does not make it best effort.
What I am questioning is if it makes sense to stop the fetching
part. When we fetch to update multiple refs, we do not stop at the
first ref-update failure, but try to do as much as possible and then
report an error, no? It is the same thing.
next prev parent reply other threads:[~2022-01-28 18:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 15:37 [PATCH] fetch --prune: exit with error if pruning fails Thomas Gummerer
2022-01-27 19:57 ` Junio C Hamano
2022-01-28 10:13 ` Johannes Schindelin
2022-01-28 10:55 ` Thomas Gummerer
2022-01-28 12:36 ` Johannes Schindelin
2022-01-28 18:14 ` Junio C Hamano [this message]
2022-01-28 11:04 ` Thomas Gummerer
2022-01-28 12:34 ` Johannes Schindelin
2022-01-31 13:07 ` Thomas Gummerer
2022-01-31 13:30 ` [PATCH v2] " Thomas Gummerer
2022-01-31 19:20 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpmobwwvg.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
--cc=t.gummerer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).