From: Junio C Hamano <gitster@pobox.com>
To: Thomas Gummerer <t.gummerer@gmail.com>
Cc: git@vger.kernel.org,
Johannes Schindelin <johannes.schindelin@gmx.de>,
Taylor Blau <me@ttaylorr.com>
Subject: Re: [PATCH v2] fetch --prune: exit with error if pruning fails
Date: Mon, 31 Jan 2022 11:20:50 -0800 [thread overview]
Message-ID: <xmqqh79jiuel.fsf@gitster.g> (raw)
In-Reply-To: <20220131133047.1885074-1-t.gummerer@gmail.com> (Thomas Gummerer's message of "Mon, 31 Jan 2022 13:30:47 +0000")
Thomas Gummerer <t.gummerer@gmail.com> writes:
> diff --git a/builtin/fetch.c b/builtin/fetch.c
> index 5f06b21f8e..648f0694f2 100644
> --- a/builtin/fetch.c
> +++ b/builtin/fetch.c
> @@ -1609,12 +1609,14 @@ static int do_fetch(struct transport *transport,
> * don't care whether --tags was specified.
> */
> if (rs->nr) {
> - prune_refs(rs, ref_map, transport->url);
> + retcode = prune_refs(rs, ref_map, transport->url);
> } else {
> - prune_refs(&transport->remote->fetch,
> - ref_map,
> - transport->url);
> + retcode = prune_refs(&transport->remote->fetch,
> + ref_map,
> + transport->url);
> }
> + if (retcode != 0)
> + retcode = 1;
> }
Looks trivially correct, even though a few style things look a bit
irritating to my eyes ;-).
Thanks, will queue.
prev parent reply other threads:[~2022-01-31 19:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 15:37 [PATCH] fetch --prune: exit with error if pruning fails Thomas Gummerer
2022-01-27 19:57 ` Junio C Hamano
2022-01-28 10:13 ` Johannes Schindelin
2022-01-28 10:55 ` Thomas Gummerer
2022-01-28 12:36 ` Johannes Schindelin
2022-01-28 18:14 ` Junio C Hamano
2022-01-28 11:04 ` Thomas Gummerer
2022-01-28 12:34 ` Johannes Schindelin
2022-01-31 13:07 ` Thomas Gummerer
2022-01-31 13:30 ` [PATCH v2] " Thomas Gummerer
2022-01-31 19:20 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh79jiuel.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=johannes.schindelin@gmx.de \
--cc=me@ttaylorr.com \
--cc=t.gummerer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).