git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
* What's cooking in git.git (Sep 2016, #03; Fri, 9)
@ 2016-09-09 22:47 Junio C Hamano
  2016-09-12 16:46 ` Jeff King
  0 siblings, 1 reply; 4+ messages in thread
From: Junio C Hamano @ 2016-09-09 22:47 UTC (permalink / raw)
  To: git

Here are the topics that have been cooking.  Commits prefixed with
'-' are only in 'pu' (proposed updates) while commits prefixed with
'+' are in 'next'.  The ones marked with '.' do not appear in any of
the integration branches, but I am still holding onto them.

I've started merging topics that have been cooking in 'next' to
'master', and the next step will be to rewind and rebuild 'next',
and merge those that have been waiting in 'pu' to 'next'.  There are
a few more topics in flight that may be ready to be picked up but I
haven't, and other topics in flight that may not be quite ready.
They will be picked up after topics that have already been in-tree
starts quieting down.

You can find the changes described here in the integration branches
of the repositories listed at

    http://git-blame.blogspot.com/p/git-public-repositories.html

--------------------------------------------------
[Graduated to "master"]

* bh/diff-highlight-graph (2016-08-31) 6 commits
  (merged to 'next' on 2016-08-31 at 523a15f)
 + diff-highlight: avoid highlighting combined diffs
 + diff-highlight: add multi-byte tests
 + diff-highlight: ignore test cruft
 + diff-highlight: add support for --graph output
 + diff-highlight: add failing test for handling --graph output
 + diff-highlight: add some tests

 "diff-highlight" script (in contrib/) learned to work better with
 "git log -p --graph" output.


* cc/receive-pack-limit (2016-08-24) 3 commits
  (merged to 'next' on 2016-08-25 at bc74b5b)
 + receive-pack: allow a maximum input size to be specified
 + unpack-objects: add --max-input-size=<size> option
 + index-pack: add --max-input-size=<size> option

 An incoming "git push" that attempts to push too many bytes can now
 be rejected by setting a new configuration variable at the receiving
 end.


* hv/doc-commit-reference-style (2016-08-26) 1 commit
  (merged to 'next' on 2016-08-31 at 68fb778)
 + SubmittingPatches: use gitk's "Copy commit summary" format

 A small doc update.


* jh/status-v2-porcelain (2016-08-12) 9 commits
  (merged to 'next' on 2016-08-31 at e71f595)
 + status: unit tests for --porcelain=v2
 + test-lib-functions.sh: add lf_to_nul helper
 + git-status.txt: describe --porcelain=v2 format
 + status: print branch info with --porcelain=v2 --branch
 + status: print per-file porcelain v2 status data
 + status: collect per-file data for --porcelain=v2
 + status: support --porcelain[=<version>]
 + status: cleanup API to wt_status_print
 + status: rename long-format print routines

 Enhance "git status --porcelain" output by collecting more data on
 the state of the index and the working tree files, which may
 further be used to teach git-prompt (in contrib/) to make fewer
 calls to git.


* jk/delta-base-cache (2016-08-23) 7 commits
  (merged to 'next' on 2016-08-25 at f1c141a)
 + t/perf: add basic perf tests for delta base cache
 + delta_base_cache: use hashmap.h
 + delta_base_cache: drop special treatment of blobs
 + delta_base_cache: use list.h for LRU
 + release_delta_base_cache: reuse existing detach function
 + clear_delta_base_cache_entry: use a more descriptive name
 + cache_or_unpack_entry: drop keep_cache parameter

 The delta-base-cache mechanism has been a key to the performance in
 a repository with a tightly packed packfile, but it did not scale
 well even with a larger value of core.deltaBaseCacheLimit.


* jk/format-patch-number-singleton-patch-with-cover (2016-08-23) 1 commit
  (merged to 'next' on 2016-08-25 at a4737fb)
 + format-patch: show 0/1 and 1/1 for singleton patch with cover letter

 "git format-patch --cover-letter HEAD^" to format a single patch
 with a separate cover letter now numbers the output as [PATCH 0/1]
 and [PATCH 1/1] by default.


* po/range-doc (2016-08-13) 12 commits
  (merged to 'next' on 2016-08-31 at d29870b)
 + doc: revisions: sort examples and fix alignment of the unchanged
 + doc: revisions: show revision expansion in examples
 + doc: revisions - clarify reachability examples
 + doc: revisions - define `reachable`
 + doc: gitrevisions - clarify 'latter case' is revision walk
 + doc: gitrevisions - use 'reachable' in page description
 + doc: revisions: single vs multi-parent notation comparison
 + doc: revisions: extra clarification of <rev>^! notation effects
 + doc: revisions: give headings for the two and three dot notations
 + doc: show the actual left, right, and boundary marks
 + doc: revisions - name the left and right sides
 + doc: use 'symmetric difference' consistently

 Clarify various ways to specify the "revision ranges" in the
 documentation.


* rt/help-unknown (2016-08-30) 3 commits
  (merged to 'next' on 2016-08-30 at db2a5b0)
 + help: make option --help open man pages only for Git commands
 + help: introduce option --exclude-guides
 + Merge branch 'js/no-html-bypass-on-windows' into rt/help-unknown

 "git nosuchcommand --help" said "No manual entry for gitnosuchcommand",
 which was not intuitive, given that "git nosuchcommand" said "git:
 'nosuchcommand' is not a git command".


* sb/submodule-clone-rr (2016-08-17) 8 commits
  (merged to 'next' on 2016-08-31 at 08b4b7d)
 + clone: recursive and reference option triggers submodule alternates
 + clone: implement optional references
 + clone: clarify option_reference as required
 + clone: factor out checking for an alternate path
 + submodule--helper update-clone: allow multiple references
 + submodule--helper module-clone: allow multiple references
 + t7408: merge short tests, factor out testing method
 + t7408: modernize style

 "git clone --resurse-submodules --reference $path $URL" is a way to
 reduce network transfer cost by borrowing objects in an existing
 $path repository when cloning the superproject from $URL; it
 learned to also peek into $path for presense of corresponding
 repositories of submodules and borrow objects from there when able.

--------------------------------------------------
[New Topics]

* jk/patch-ids-no-merges (2016-09-09) 2 commits
 - patch-ids: define patch-id of merge commits as "null"
 - patch-ids: turn off rename detection

 "git log --cherry-pick" used to include merge commits as candidates
 to be matched up with other commits, resulting a lot of wasted time.
 The patch-id generation logic has been updated to ignore merges to
 avoid the wastage.

 Will merge to 'next'.


* js/git-gui-commit-gpgsign (2016-09-09) 2 commits
 - Merge branch 'js/commit-gpgsign' of ../git-gui into js/git-gui-commit-gpgsign
 - git-gui: respect commit.gpgsign again

 "git commit-tree" stopped reading commit.gpgsign configuration
 variable that was meant for Porcelain "git commit" in Git 2.9; we
 forgot to update "git gui" to look at the configuration to match
 this change.

 Will merge to 'next'.

--------------------------------------------------
[Stalled]

* jc/bundle (2016-03-03) 6 commits
 - index-pack: --clone-bundle option
 - Merge branch 'jc/index-pack' into jc/bundle
 - bundle v3: the beginning
 - bundle: keep a copy of bundle file name in the in-core bundle header
 - bundle: plug resource leak
 - bundle doc: 'verify' is not about verifying the bundle

 The beginning of "split bundle", which could be one of the
 ingredients to allow "git clone" traffic off of the core server
 network to CDN.

 While I think it would make it easier for people to experiment and
 build on if the topic is merged to 'next', I am at the same time a
 bit reluctant to merge an unproven new topic that introduces a new
 file format, which we may end up having to support til the end of
 time.  It is likely that to support a "prime clone from CDN", it
 would need a lot more than just "these are the heads and the pack
 data is over there", so this may not be sufficient.

 Will discard.


* jc/blame-reverse (2016-06-14) 2 commits
 - blame: dwim "blame --reverse OLD" as "blame --reverse OLD.."
 - blame: improve diagnosis for "--reverse NEW"

 It is a common mistake to say "git blame --reverse OLD path",
 expecting that the command line is dwimmed as if asking how lines
 in path in an old revision OLD have survived up to the current
 commit.

 Has been waiting for positive responses without seeing any.

 Will discard.


* jc/attr (2016-05-25) 18 commits
 - attr: support quoting pathname patterns in C style
 - attr: expose validity check for attribute names
 - attr: add counted string version of git_attr()
 - attr: add counted string version of git_check_attr()
 - attr: retire git_check_attrs() API
 - attr: convert git_check_attrs() callers to use the new API
 - attr: convert git_all_attrs() to use "struct git_attr_check"
 - attr: (re)introduce git_check_attr() and struct git_attr_check
 - attr: rename function and struct related to checking attributes
 - attr.c: plug small leak in parse_attr_line()
 - attr.c: tighten constness around "git_attr" structure
 - attr.c: simplify macroexpand_one()
 - attr.c: mark where #if DEBUG ends more clearly
 - attr.c: complete a sentence in a comment
 - attr.c: explain the lack of attr-name syntax check in parse_attr()
 - attr.c: update a stale comment on "struct match_attr"
 - attr.c: use strchrnul() to scan for one line
 - commit.c: use strchrnul() to scan for one line
 (this branch is used by jc/attr-more, sb/pathspec-label and sb/submodule-default-paths.)

 The attributes API has been updated so that it can later be
 optimized using the knowledge of which attributes are queried.

 I wanted to polish this topic further to make the attribute
 subsystem thread-ready, but because other topics depend on this
 topic and they do not (yet) need it to be thread-ready.

 As the authors of topics that depend on this seem not in a hurry,
 let's discard this and dependent topics and restart them some other
 day.

 Will discard.


* jc/attr-more (2016-06-09) 8 commits
 - attr.c: outline the future plans by heavily commenting
 - attr.c: always pass check[] to collect_some_attrs()
 - attr.c: introduce empty_attr_check_elems()
 - attr.c: correct ugly hack for git_all_attrs()
 - attr.c: rename a local variable check
 - fixup! d5ad6c13
 - attr.c: pass struct git_attr_check down the callchain
 - attr.c: add push_stack() helper
 (this branch uses jc/attr; is tangled with sb/pathspec-label and sb/submodule-default-paths.)

 The beginning of long and tortuous journey to clean-up attribute
 subsystem implementation.

 Needs to be redone.
 Will discard.


* sb/submodule-default-paths (2016-06-20) 5 commits
 - completion: clone can recurse into submodules
 - clone: add --init-submodule=<pathspec> switch
 - submodule update: add `--init-default-path` switch
 - Merge branch 'sb/pathspec-label' into sb/submodule-default-paths
 - Merge branch 'jc/attr' into sb/submodule-default-paths
 (this branch uses jc/attr and sb/pathspec-label; is tangled with jc/attr-more.)

 Allow specifying the set of submodules the user is interested in on
 the command line of "git clone" that clones the superproject.

 Will discard.


* sb/pathspec-label (2016-06-03) 6 commits
 - pathspec: disable preload-index when attribute pathspec magic is in use
 - pathspec: allow escaped query values
 - pathspec: allow querying for attributes
 - pathspec: move prefix check out of the inner loop
 - pathspec: move long magic parsing out of prefix_pathspec
 - Documentation: fix a typo
 (this branch is used by sb/submodule-default-paths; uses jc/attr; is tangled with jc/attr-more.)

 The pathspec mechanism learned ":(attr:X)$pattern" pathspec magic
 to limit paths that match $pattern further by attribute settings.
 The preload-index mechanism is disabled when the new pathspec magic
 is in use (at least for now), because the attribute subsystem is
 not thread-ready.

 Will discard.


* mh/connect (2016-06-06) 10 commits
 - connect: [host:port] is legacy for ssh
 - connect: move ssh command line preparation to a separate function
 - connect: actively reject git:// urls with a user part
 - connect: change the --diag-url output to separate user and host
 - connect: make parse_connect_url() return the user part of the url as a separate value
 - connect: group CONNECT_DIAG_URL handling code
 - connect: make parse_connect_url() return separated host and port
 - connect: re-derive a host:port string from the separate host and port variables
 - connect: call get_host_and_port() earlier
 - connect: document why we sometimes call get_port after get_host_and_port

 Rewrite Git-URL parsing routine (hopefully) without changing any
 behaviour.

 It has been two months without any support.  We may want to discard
 this.


* sb/bisect (2016-04-15) 22 commits
 . SQUASH???
 . bisect: get back halfway shortcut
 . bisect: compute best bisection in compute_relevant_weights()
 . bisect: use a bottom-up traversal to find relevant weights
 . bisect: prepare for different algorithms based on find_all
 . bisect: rename count_distance() to compute_weight()
 . bisect: make total number of commits global
 . bisect: introduce distance_direction()
 . bisect: extract get_distance() function from code duplication
 . bisect: use commit instead of commit list as arguments when appropriate
 . bisect: replace clear_distance() by unique markers
 . bisect: use struct node_data array instead of int array
 . bisect: get rid of recursion in count_distance()
 . bisect: make algorithm behavior independent of DEBUG_BISECT
 . bisect: make bisect compile if DEBUG_BISECT is set
 . bisect: plug the biggest memory leak
 . bisect: add test for the bisect algorithm
 . t6030: generalize test to not rely on current implementation
 . t: use test_cmp_rev() where appropriate
 . t/test-lib-functions.sh: generalize test_cmp_rev
 . bisect: allow 'bisect run' if no good commit is known
 . bisect: write about `bisect next` in documentation

 The internal algorithm used in "git bisect" to find the next commit
 to check has been optimized greatly.

 Was expecting a reroll, but now pb/bisect topic starts removinging
 more and more parts from git-bisect.sh, this needs to see a fresh
 reroll.

 Will discard.
 cf. <1460294354-7031-1-git-send-email-s-beyer@gmx.net>


* sg/completion-updates (2016-02-28) 21 commits
 . completion: cache the path to the repository
 . completion: extract repository discovery from __gitdir()
 . completion: don't guard git executions with __gitdir()
 . completion: consolidate silencing errors from git commands
 . completion: don't use __gitdir() for git commands
 . completion: respect 'git -C <path>'
 . completion: fix completion after 'git -C <path>'
 . completion: don't offer commands when 'git --opt' needs an argument
 . rev-parse: add '--absolute-git-dir' option
 . completion: list short refs from a remote given as a URL
 . completion: don't list 'HEAD' when trying refs completion outside of a repo
 . completion: list refs from remote when remote's name matches a directory
 . completion: respect 'git --git-dir=<path>' when listing remote refs
 . completion: fix most spots not respecting 'git --git-dir=<path>'
 . completion: ensure that the repository path given on the command line exists
 . completion tests: add tests for the __git_refs() helper function
 . completion tests: check __gitdir()'s output in the error cases
 . completion tests: consolidate getting path of current working directory
 . completion tests: make the $cur variable local to the test helper functions
 . completion tests: don't add test cruft to the test repository
 . completion: improve __git_refs()'s in-code documentation

 Has been waiting for a reroll for too long.
 cf. <1456754714-25237-1-git-send-email-szeder@ira.uka.de>

 Will discard.


* ec/annotate-deleted (2015-11-20) 1 commit
 - annotate: skip checking working tree if a revision is provided

 Usability fix for annotate-specific "<file> <rev>" syntax with deleted
 files.

 Has been waiting for a review for too long without seeing anything.

 Will discard.


* dk/gc-more-wo-pack (2016-01-13) 4 commits
 - gc: clean garbage .bitmap files from pack dir
 - t5304: ensure non-garbage files are not deleted
 - t5304: test .bitmap garbage files
 - prepare_packed_git(): find more garbage

 Follow-on to dk/gc-idx-wo-pack topic, to clean up stale
 .bitmap and .keep files.

 Has been waiting for a reroll for too long.
 cf. <xmqq60ypbeng.fsf@gitster.mtv.corp.google.com>

 Will discard.


* jc/diff-b-m (2015-02-23) 5 commits
 . WIPWIP
 . WIP: diff-b-m
 - diffcore-rename: allow easier debugging
 - diffcore-rename.c: add locate_rename_src()
 - diffcore-break: allow debugging

 "git diff -B -M" produced incorrect patch when the postimage of a
 completely rewritten file is similar to the preimage of a removed
 file; such a resulting file must not be expressed as a rename from
 other place.

 The fix in this patch is broken, unfortunately.

 Will discard.

--------------------------------------------------
[Cooking]

* bc/object-id (2016-09-07) 20 commits
 - builtin/reset: convert to use struct object_id
 - builtin/commit-tree: convert to struct object_id
 - builtin/am: convert to struct object_id
 - refs: add an update_ref_oid function.
 - sha1_name: convert get_sha1_mb to struct object_id
 - builtin/update-index: convert file to struct object_id
 - notes: convert init_notes to use struct object_id
 - builtin/rm: convert to use struct object_id
 - builtin/blame: convert file to use struct object_id
 - Convert read_mmblob to take struct object_id.
 - notes-merge: convert struct notes_merge_pair to struct object_id
 - builtin/checkout: convert some static functions to struct object_id
 - streaming: make stream_blob_to_fd take struct object_id
 - builtin: convert textconv_object to use struct object_id
 - builtin/cat-file: convert some static functions to struct object_id
 - builtin/cat-file: convert struct expand_data to use struct object_id
 - builtin/log: convert some static functions to use struct object_id
 - builtin/blame: convert struct origin to use struct object_id
 - builtin/apply: convert static functions to struct object_id
 - cache: convert struct cache_entry to use struct object_id

 The "unsigned char sha1[20]" to "struct object_id" conversion
 continues.  Notable changes in this round includes that ce->sha1,
 i.e. the object name recorded in the cache_entry, turns into an
 object_id.

 It had merge conflicts with a few topics in flight (Christian's
 "apply.c split", Dscho's "cat-file --filters" and Jeff Hostetler's
 "status --porcelain-v2").  Extra sets of eyes double-checking for
 mismerges are highly appreciated.


* ep/use-git-trace-curl-in-tests (2016-09-07) 4 commits
  (merged to 'next' on 2016-09-08 at 04372de)
 + t5551-http-fetch-smart.sh: use the GIT_TRACE_CURL environment var
 + t5550-http-fetch-dumb.sh: use the GIT_TRACE_CURL environment var
 + test-lib.sh: preserve GIT_TRACE_CURL from the environment
 + t5541-http-push-smart.sh: use the GIT_TRACE_CURL environment var

 Update a few tests that used to use GIT_CURL_VERBOSE to use the
 newer GIT_TRACE_CURL.

 Will merge to 'master'.


* jk/pack-tag-of-tag (2016-09-07) 5 commits
 - pack-objects: walk tag chains for --include-tag
 - t5305: simplify packname handling
 - t5305: use "git -C"
 - t5305: drop "dry-run" of unpack-objects
 - t5305: move cleanup into test block

 "git pack-objects --include-tag" was taught that when we know that
 we are sending an object C, we want a tag B that directly points at
 C but also a tag A that points at the tag B.  We used to miss the
 intermediate tag B in some cases.

 Will merge to 'next'.


* js/t6026-clean-up (2016-09-07) 1 commit
  (merged to 'next' on 2016-09-08 at 5ad2fc1)
 + t6026-merge-attr: clean up background process at end of test case

 A test spawned a short-lived background process, which sometimes
 prevented the test directory from getting removed at the end of the
 script on some platforms.

 Will merge to 'master'.


* js/t9903-chaining (2016-09-07) 1 commit
  (merged to 'next' on 2016-09-08 at 162a3c9)
 + t9903: fix broken && chain

 Will merge to 'master'.


* jt/accept-capability-advertisement-when-fetching-from-void (2016-09-09) 3 commits
 - connect: advertized capability is not a ref
 - connect: tighten check for unexpected early hang up
 - tests: move test_lazy_prereq JGIT to test-lib.sh

 JGit can show a fake ref "capabilities^{}" to "git fetch" when it
 does not advertise any refs, but "git fetch" was not prepared to
 see such an advertisement.  When the other side disconnects without
 giving any ref advertisement, we used to say "there may not be a
 repository at that URL", but we may have seen other advertisement
 like "shallow" and ".have" in which case we definitely know that a
 repository is there.  The code to detect this case has also been
 updated.

 Will merge to 'next'.


* rs/compat-strdup (2016-09-07) 1 commit
  (merged to 'next' on 2016-09-08 at 46acfdf)
 + compat: move strdup(3) replacement to its own file

 Will merge to 'master'.


* rs/hex2chr (2016-09-07) 1 commit
  (merged to 'next' on 2016-09-08 at 7266d5b)
 + introduce hex2chr() for converting two hexadecimal digits to a character

 Will merge to 'master'.


* rt/rebase-i-broken-insn-advise (2016-09-07) 1 commit
 - rebase -i: improve advice on bad instruction lines

 When "git rebase -i" is given a broken instruction, it told the
 user to fix it with "--edit-todo", but didn't say what the step
 after that was (i.e. "--continue").

 Will hold.
 Dscho's "rebase -i" hopefully will become available in 'pu', by
 which time an equivalent of this fix would be ported to C.  This is
 queued merely as a reminder.


* sb/xdiff-remove-unused-static-decl (2016-09-07) 1 commit
  (merged to 'next' on 2016-09-08 at 39e41dd)
 + xdiff: remove unneeded declarations

 Code cleanup.

 Will merge to 'master'.


* sy/git-gui-i18n-ja (2016-09-07) 7 commits
 - Merge branch 'sy/i18n' of git-gui
 - git-gui: update Japanese information
 - git-gui: update Japanese translation
 - git-gui: add Japanese language code
 - git-gui: apply po template to Japanese translation
 - git-gui: consistently use the same word for "blame" in Japanese
 - git-gui: consistently use the same word for "remote" in Japanese

 Update Japanese translation for "git-gui".

 Will merge to 'next'.


* ah/misc-message-fixes (2016-09-08) 5 commits
 - unpack-trees: do not capitalize "working"
 - git-merge-octopus: do not capitalize "octopus"
 - git-rebase--interactive: fix English grammar
 - cat-file: put spaces around pipes in usage string
 - am: put spaces around pipe in usage string

 Message cleanup.

 Will merge to 'next'.


* jk/fix-remote-curl-url-wo-proto (2016-09-08) 1 commit
 - remote-curl: handle URLs without protocol

 "git fetch http::/site/path" did not die correctly and segfaulted
 instead.

 Will merge to 'next'.


* jt/format-patch-base-info-above-sig (2016-09-09) 1 commit
 - format-patch: show base info before email signature

 "git format-patch --base=..." feature that was recently added
 showed the base commit information after "-- " e-mail signature
 line, which turned out to be inconvenient.  The base information
 has been moved above the signature line.

 Needs an extra blank line before the baseinfo.


* nd/checkout-disambiguation (2016-09-09) 4 commits
 - fixup! checkout.txt: document a common case that ignores ambiguation rules
 - checkout: fix ambiguity check in subdir
 - checkout.txt: document a common case that ignores ambiguation rules
 - checkout: add some spaces between code and comment

 "git checkout <word>" does not follow the usual disambiguation
 rules when the <word> can be both a rev and a path, to allow
 checking out a branch 'foo' in a project that happens to have a
 file 'foo' in the working tree without having to disambiguate.
 This was poorly documented and the check was incorrect when the
 command was run from a subdirectory.

 Waiting for an Ack for fixup!


* sb/diff-cleanup (2016-09-08) 3 commits
 - diff: remove dead code
 - diff: omit found pointer from emit_callback
 - diff.c: use diff_options directly

 Code cleanup.

 Will merge to 'next'.


* sb/transport-report-missing-submodule-on-stderr (2016-09-08) 1 commit
  (merged to 'next' on 2016-09-08 at 3550831)
 + transport: report missing submodule pushes consistently on stderr

 Message cleanup.

 Will merge to 'master'.


* sg/fix-versioncmp-with-common-suffix (2016-09-08) 5 commits
 - versioncmp: cope with common leading parts in versionsort.prereleaseSuffix
 - versioncmp: pass full tagnames to swap_prereleases()
 - t7004-tag: add version sort tests to show prerelease reordering issues
 - t7004-tag: use test_config helper
 - t7004-tag: delete unnecessary tags with test_when_finished

 The prereleaseSuffix feature of version comparison that is used in
 "git tag -l" did not correctly when two or more prereleases for the
 same release were present (e.g. when 2.0, 2.0-beta1, and 2.0-beta2
 are there and the code needs to compare 2.0-beta1 and 2.0-beta2).

 Waiting for a reroll.
 cf. <20160908223727.Horde.jVOOJ278ssZ3qkyjkmyqZD-@webmail.informatik.kit.edu>


* va/i18n (2016-09-09) 10 commits
 - i18n: update-index: mark warning for translation
 - i18n: show-branch: mark error messages for translation
 - i18n: receive-pack: mark messages for translation
 - notes: downcase the first word of error messages
 - i18n: notes: mark error messages for translation
 - i18n: merge-recursive: mark verbose message for translation
 - i18n: merge-recursive: mark error messages for translation
 - i18n: config: mark error message for translation
 - i18n: branch: mark option description for translation
 - i18n: blame: mark error messages for translation

 More i18n.

 Will merge to 'next'.


* jc/submodule-anchor-git-dir (2016-09-01) 1 commit
  (merged to 'next' on 2016-09-08 at b6f20cf)
 + submodule: avoid auto-discovery in prepare_submodule_repo_env()

 Having a submodule whose ".git" repository is somehow corrupt
 caused a few commands that recurse into submodules loop forever.

 Will merge to 'master'.


* jc/forbid-symbolic-ref-d-HEAD (2016-09-02) 1 commit
  (merged to 'next' on 2016-09-08 at cd8c1b3)
 + symbolic-ref -d: do not allow removal of HEAD

 "git symbolic-ref -d HEAD" happily removes the symbolic ref, but
 the resulting repository becomes an invalid one.  Teach the command
 to forbid removal of HEAD.

 Will merge to 'master'.


* jc/am-read-author-file (2016-08-30) 1 commit
  (merged to 'next' on 2016-09-08 at d2db42f)
 + am: refactor read_author_script()

 Extract a small helper out of the function that reads the authors
 script file "git am" internally uses.

 Will merge to 'master'.
 This by itself is not useful until a second caller appears in the
 future for "rebase -i" helper.


* jk/test-lib-drop-pid-from-results (2016-08-30) 1 commit
  (merged to 'next' on 2016-09-08 at 0967b0b)
 + test-lib: drop PID from test-results/*.count

 The test framework left the number of tests and success/failure
 count in the t/test-results directory, keyed by the name of the
 test script plus the process ID.  The latter however turned out not
 to serve any useful purpose.  The process ID part of the filename
 has been removed.

 Will merge to 'master'.


* js/sequencer-wo-die (2016-09-09) 17 commits
 - sequencer: ensure to release the lock when we could not read the index
 - sequencer: lib'ify checkout_fast_forward()
 - sequencer: lib'ify fast_forward_to()
 - sequencer: lib'ify save_opts()
 - sequencer: lib'ify save_todo()
 - sequencer: lib'ify save_head()
 - sequencer: lib'ify create_seq_dir()
 - sequencer: lib'ify read_populate_opts()
 - sequencer: lib'ify read_populate_todo()
 - sequencer: lib'ify read_and_refresh_cache()
 - sequencer: lib'ify prepare_revs()
 - sequencer: lib'ify walk_revs_populate_todo()
 - sequencer: lib'ify do_pick_commit()
 - sequencer: lib'ify do_recursive_merge()
 - sequencer: lib'ify write_message()
 - sequencer: do not die() in do_pick_commit()
 - sequencer: lib'ify sequencer_pick_revisions()

 Lifts calls to exit(2) and die() higher in the callchain in
 sequencer.c files so that more helper functions in it can be used
 by callers that want to handle error conditions themselves.

 Will merge to 'next' after waiting for a few days for further comments.


* jk/squelch-false-warning-from-gcc-o3 (2016-08-31) 2 commits
  (merged to 'next' on 2016-09-08 at c9a2af6)
 + color_parse_mem: initialize "struct color" temporary
 + error_errno: use constant return similar to error()

 Will merge to 'master'.


* cp/completion-negative-refs (2016-08-24) 1 commit
 - completion: support excluding refs

 The command-line completion script (in contrib/) learned to
 complete "git cmd ^mas<HT>" to complete the negative end of
 reference to "git cmd ^master".

 Waiting for a review.


* js/cat-file-filters (2016-09-09) 5 commits
 - SQUASH??? "cat-file --filters" passes data as-is by default
 - cat-file: support --textconv/--filters in batch mode
 - cat-file --textconv/--filters: allow specifying the path separately
 - cat-file: introduce the --filters option
 - cat-file: fix a grammo in the man page

 Even though "git hash-objects", which is a tool to take an
 on-filesystem data stream and put it into the Git object store,
 allowed to perform the "outside-world-to-Git" conversions (e.g.
 end-of-line conversions and application of the clean-filter), and
 it had the feature on by default from very early days, its reverse
 operation "git cat-file", which takes an object from the Git object
 store and externalize for the consumption by the outside world,
 lacked an equivalent mechanism to run the "Git-to-outside-world"
 conversion.  The command learned the "--filters" option to do so.

 Waiting for an ack to SQUASH???


* sb/push-make-submodule-check-the-default (2016-08-24) 1 commit
 - push: change submodule default to check

 Turn the default of "push.recurseSubmodules" to "check".

 Alas, this reveals that the "check" mode is too inefficient to use
 in real projects, even in ones as small as git itself.
 cf. <xmqqh9aaot49.fsf@gitster.mtv.corp.google.com>


* ak/curl-imap-send-explicit-scheme (2016-08-17) 1 commit
 - imap-send: Tell cURL to use imap:// or imaps://

 When we started cURL to talk to imap server when a new enough
 version of cURL library is available, we forgot to explicitly add
 imap(s):// before the destination.  To some folks, that didn't work
 and the library tried to make HTTP(s) requests instead.

 Needs review and testing.


* jk/diff-submodule-diff-inline (2016-08-31) 8 commits
  (merged to 'next' on 2016-09-02 at 734e42c)
 + diff: teach diff to display submodule difference with an inline diff
 + submodule: refactor show_submodule_summary with helper function
 + submodule: convert show_submodule_summary to use struct object_id *
 + allow do_submodule_path to work even if submodule isn't checked out
 + diff: prepare for additional submodule formats
 + graph: add support for --line-prefix on all graph-aware output
 + diff.c: remove output_prefix_length field
 + cache: add empty_tree_oid object and helper function

 The "git diff --submodule={short,log}" mechanism has been enhanced
 to allow "--submodule=diff" to show the patch between the submodule
 commits bound to the superproject.

 Will merge to 'master'.


* jk/reduce-gc-aggressive-depth (2016-08-11) 1 commit
  (merged to 'next' on 2016-08-11 at 6810c6f)
 + gc: default aggressive depth to 50

 "git gc --aggressive" used to limit the delta-chain length to 250,
 which is way too deep for gaining additional space savings and is
 detrimental for runtime performance.  The limit has been reduced to
 50.

 Will hold to see if people scream.


* ks/pack-objects-bitmap (2016-08-09) 2 commits
 - pack-objects: use reachability bitmap index when generating non-stdout pack
 - pack-objects: respect --local/--honor-pack-keep/--incremental when bitmap is in use

 What is the state of this thing?
 Waiting for the review discussion to settle.
 cf. <20160818175222.bmm3ivjheokf2qzl@sigill.intra.peff.net>
 cf. <20160818180615.q25p57v35m2xxtww@sigill.intra.peff.net>


* mh/diff-indent-heuristic (2016-09-07) 9 commits
 - SQAUSH???
 - blame: honor the diff heuristic options and config
 - parse-options: add parse_opt_unknown_cb()
 - diff: improve positioning of add/delete blocks in diffs
 - xdl_change_compact(): introduce the concept of a change group
 - recs_match(): take two xrecord_t pointers as arguments
 - is_blank_line(): take a single xrecord_t as argument
 - xdl_change_compact(): only use heuristic if group can't be matched
 - xdl_change_compact(): fix compaction heuristic to adjust ixo

 Output from "git diff" can be made easier to read by selecting
 which lines are common and which lines are added/deleted
 intelligently when the lines before and after the changed section
 are the same.  A command line option is added to help with the
 experiment to find a good heuristics.

 Needs adjustment of test numbers.  Otherwise looked OK.
 Waiting for an ack to SQUASH???


* cc/apply-am (2016-09-07) 41 commits
 - builtin/am: use apply API in run_apply()
 - apply: learn to use a different index file
 - apply: pass apply state to build_fake_ancestor()
 - apply: refactor `git apply` option parsing
 - apply: change error_routine when silent
 - usage: add get_error_routine() and get_warn_routine()
 - usage: add set_warn_routine()
 - apply: don't print on stdout in verbosity_silent mode
 - apply: make it possible to silently apply
 - apply: use error_errno() where possible
 - apply: make some parsing functions static again
 - apply: move libified code from builtin/apply.c to apply.{c,h}
 - apply: rename and move opt constants to apply.h
 - builtin/apply: rename option parsing functions
 - builtin/apply: make create_one_file() return -1 on error
 - builtin/apply: make try_create_file() return -1 on error
 - builtin/apply: make write_out_results() return -1 on error
 - builtin/apply: make write_out_one_result() return -1 on error
 - builtin/apply: make create_file() return -1 on error
 - builtin/apply: make add_index_file() return -1 on error
 - builtin/apply: make add_conflicted_stages_file() return -1 on error
 - builtin/apply: make remove_file() return -1 on error
 - builtin/apply: make build_fake_ancestor() return -1 on error
 - builtin/apply: change die_on_unsafe_path() to check_unsafe_path()
 - builtin/apply: make gitdiff_*() return -1 on error
 - builtin/apply: make gitdiff_*() return 1 at end of header
 - builtin/apply: make parse_traditional_patch() return -1 on error
 - builtin/apply: make apply_all_patches() return 128 or 1 on error
 - builtin/apply: move check_apply_state() to apply.c
 - builtin/apply: make check_apply_state() return -1 instead of die()ing
 - apply: make init_apply_state() return -1 instead of exit()ing
 - builtin/apply: move init_apply_state() to apply.c
 - builtin/apply: make parse_ignorewhitespace_option() return -1 instead of die()ing
 - builtin/apply: make parse_whitespace_option() return -1 instead of die()ing
 - builtin/apply: make parse_single_patch() return -1 on error
 - builtin/apply: make parse_chunk() return a negative integer on error
 - builtin/apply: make find_header() return -128 instead of die()ing
 - builtin/apply: read_patch_file() return -1 instead of die()ing
 - builtin/apply: make apply_patch() return -1 or -128 instead of die()ing
 - apply: move 'struct apply_state' to apply.h
 - apply: make some names more specific

 "git am" has been taught to make an internal call to "git apply"'s
 innards without spawning the latter as a separate process.

 Will merge to 'next' after waiting for a few days for further comments.


* jk/pack-objects-optim-mru (2016-08-11) 4 commits
  (merged to 'next' on 2016-08-11 at c0a7dae)
 + pack-objects: use mru list when iterating over packs
 + pack-objects: break delta cycles before delta-search phase
 + sha1_file: make packed_object_info public
 + provide an initializer for "struct object_info"

 "git pack-objects" in a repository with many packfiles used to
 spend a lot of time looking for/at objects in them; the accesses to
 the packfiles are now optimized by checking the most-recently-used
 packfile first.

 Will hold to see if people scream.


* jk/rebase-i-drop-ident-check (2016-07-29) 1 commit
  (merged to 'next' on 2016-08-14 at 6891bcd)
 + rebase-interactive: drop early check for valid ident

 Even when "git pull --rebase=preserve" (and the underlying "git
 rebase --preserve") can complete without creating any new commit
 (i.e. fast-forwards), it still insisted on having a usable ident
 information (read: user.email is set correctly), which was less
 than nice.  As the underlying commands used inside "git rebase"
 would fail with a more meaningful error message and advice text
 when the bogus ident matters, this extra check was removed.

 Will hold to see if people scream.
 cf. <20160729224944.GA23242@sigill.intra.peff.net>


* dp/autoconf-curl-ssl (2016-06-28) 1 commit
 - ./configure.ac: detect SSL in libcurl using curl-config

 The ./configure script generated from configure.ac was taught how
 to detect support of SSL by libcurl better.

 Needs review.


* jc/pull-rebase-ff (2016-07-28) 1 commit
 - pull: fast-forward "pull --rebase=true"

 "git pull --rebase", when there is no new commits on our side since
 we forked from the upstream, should be able to fast-forward without
 invoking "git rebase", but it didn't.

 Needs a real log message and a few tests.


* ex/deprecate-empty-pathspec-as-match-all (2016-06-22) 1 commit
  (merged to 'next' on 2016-07-13 at d9ca7fb)
 + pathspec: warn on empty strings as pathspec

 An empty string used as a pathspec element has always meant
 'everything matches', but it is too easy to write a script that
 finds a path to remove in $path and run 'git rm "$paht"', which
 ends up removing everything.  Start warning about this use of an
 empty string used for 'everything matches' and ask users to use a
 more explicit '.' for that instead.

 The hope is that existing users will not mind this change, and
 eventually the warning can be turned into a hard error, upgrading
 the deprecation into removal of this (mis)feature.

 Will hold to see if people scream.


* mh/ref-store (2016-09-09) 38 commits
 - refs: implement iteration over only per-worktree refs
 - refs: make lock generic
 - refs: add method to rename refs
 - refs: add methods to init refs db
 - refs: make delete_refs() virtual
 - refs: add method for initial ref transaction commit
 - refs: add methods for reflog
 - refs: add method iterator_begin
 - files_ref_iterator_begin(): take a ref_store argument
 - split_symref_update(): add a files_ref_store argument
 - lock_ref_sha1_basic(): add a files_ref_store argument
 - lock_ref_for_update(): add a files_ref_store argument
 - commit_ref_update(): add a files_ref_store argument
 - lock_raw_ref(): add a files_ref_store argument
 - repack_without_refs(): add a files_ref_store argument
 - refs: make peel_ref() virtual
 - refs: make create_symref() virtual
 - refs: make pack_refs() virtual
 - refs: make verify_refname_available() virtual
 - refs: make read_raw_ref() virtual
 - resolve_gitlink_ref(): rename path parameter to submodule
 - resolve_gitlink_ref(): avoid memory allocation in many cases
 - resolve_gitlink_ref(): implement using resolve_ref_recursively()
 - resolve_ref_recursively(): new function
 - read_raw_ref(): take a (struct ref_store *) argument
 - resolve_gitlink_packed_ref(): remove function
 - resolve_packed_ref(): rename function from resolve_missing_loose_ref()
 - refs: reorder definitions
 - refs: add a transaction_commit() method
 - {lock,commit,rollback}_packed_refs(): add files_ref_store arguments
 - resolve_missing_loose_ref(): add a files_ref_store argument
 - get_packed_ref(): add a files_ref_store argument
 - add_packed_ref(): add a files_ref_store argument
 - refs: create a base class "ref_store" for files_ref_store
 - refs: add a backend method structure
 - refs: rename struct ref_cache to files_ref_store
 - rename_ref_available(): add docstring
 - resolve_gitlink_ref(): eliminate temporary variable

 The ref-store abstraction was introduced to the refs API so that we
 can plug in different backends to store references.

 Will merge to 'next' after waiting for a few days for further comments.
 


* nd/shallow-deepen (2016-06-13) 27 commits
 - fetch, upload-pack: --deepen=N extends shallow boundary by N commits
 - upload-pack: add get_reachable_list()
 - upload-pack: split check_unreachable() in two, prep for get_reachable_list()
 - t5500, t5539: tests for shallow depth excluding a ref
 - clone: define shallow clone boundary with --shallow-exclude
 - fetch: define shallow boundary with --shallow-exclude
 - upload-pack: support define shallow boundary by excluding revisions
 - refs: add expand_ref()
 - t5500, t5539: tests for shallow depth since a specific date
 - clone: define shallow clone boundary based on time with --shallow-since
 - fetch: define shallow boundary with --shallow-since
 - upload-pack: add deepen-since to cut shallow repos based on time
 - shallow.c: implement a generic shallow boundary finder based on rev-list
 - fetch-pack: use a separate flag for fetch in deepening mode
 - fetch-pack.c: mark strings for translating
 - fetch-pack: use a common function for verbose printing
 - fetch-pack: use skip_prefix() instead of starts_with()
 - upload-pack: move rev-list code out of check_non_tip()
 - upload-pack: make check_non_tip() clean things up on error
 - upload-pack: tighten number parsing at "deepen" lines
 - upload-pack: use skip_prefix() instead of starts_with()
 - upload-pack: move "unshallow" sending code out of deepen()
 - upload-pack: remove unused variable "backup"
 - upload-pack: move "shallow" sending code out of deepen()
 - upload-pack: move shallow deepen code out of receive_needs()
 - transport-helper.c: refactor set_helper_option()
 - remote-curl.c: convert fetch_git() to use argv_array

 The existing "git fetch --depth=<n>" option was hard to use
 correctly when making the history of an existing shallow clone
 deeper.  A new option, "--deepen=<n>", has been added to make this
 easier to use.  "git clone" also learned "--shallow-since=<date>"
 and "--shallow-exclude=<tag>" options to make it easier to specify
 "I am interested only in the recent N months worth of history" and
 "Give me only the history since that version".

 Needs review.

 Rerolled.  What this topic attempts to achieve is worthwhile, I
 would think.


* pb/bisect (2016-08-23) 27 commits
 . bisect--helper: remove the dequote in bisect_start()
 . bisect--helper: retire `--bisect-auto-next` subcommand
 . bisect--helper: retire `--bisect-autostart` subcommand
 . bisect--helper: retire `--check-and-set-terms` subcommand
 . bisect--helper: retire `--bisect-write` subcommand
 . bisect--helper: `bisect_replay` shell function in C
 . bisect--helper: `bisect_log` shell function in C
 . bisect--helper: retire `--write-terms` subcommand
 . bisect--helper: retire `--check-expected-revs` subcommand
 . bisect--helper: `bisect_state` & `bisect_head` shell function in C
 . bisect--helper: `bisect_autostart` shell function in C
 . bisect--helper: retire `--next-all` subcommand
 . bisect--helper: retire `--bisect-clean-state` subcommand
 . bisect--helper: `bisect_next` and `bisect_auto_next` shell function in C
 . bisect--helper: `bisect_start` shell function partially in C
 . bisect--helper: `get_terms` & `bisect_terms` shell function in C
 . bisect--helper: `bisect_next_check` & bisect_voc shell function in C
 . bisect--helper: `check_and_set_terms` shell function in C
 . bisect--helper: `bisect_write` shell function in C
 . bisect--helper: `is_expected_rev` & `check_expected_revs` shell function in C
 . bisect--helper: `bisect_reset` shell function in C
 . wrapper: move is_empty_file() and rename it as is_empty_or_missing_file()
 . t6030: explicitly test for bisection cleanup
 . bisect--helper: `bisect_clean_state` shell function in C
 . bisect--helper: `write_terms` shell function in C
 . bisect: rewrite `check_term_format` shell function in C
 . bisect--helper: use OPT_CMDMODE instead of OPT_BOOL

 GSoC "bisect" topic.

 I'd prefer to see early part solidified so that reviews can focus
 on the later part that is still in flux.  We are almost there but
 not quite yet.


* kn/ref-filter-branch-list (2016-05-17) 17 commits
 - branch: implement '--format' option
 - branch: use ref-filter printing APIs
 - branch, tag: use porcelain output
 - ref-filter: allow porcelain to translate messages in the output
 - ref-filter: add `:dir` and `:base` options for ref printing atoms
 - ref-filter: make remote_ref_atom_parser() use refname_atom_parser_internal()
 - ref-filter: introduce symref_atom_parser() and refname_atom_parser()
 - ref-filter: introduce refname_atom_parser_internal()
 - ref-filter: make "%(symref)" atom work with the ':short' modifier
 - ref-filter: add support for %(upstream:track,nobracket)
 - ref-filter: make %(upstream:track) prints "[gone]" for invalid upstreams
 - ref-filter: introduce format_ref_array_item()
 - ref-filter: move get_head_description() from branch.c
 - ref-filter: modify "%(objectname:short)" to take length
 - ref-filter: implement %(if:equals=<string>) and %(if:notequals=<string>)
 - ref-filter: include reference to 'used_atom' within 'atom_value'
 - ref-filter: implement %(if), %(then), and %(else) atoms

 The code to list branches in "git branch" has been consolidated
 with the more generic ref-filter API.

 Rerolled.
 Needs review.


* jc/merge-drop-old-syntax (2015-04-29) 1 commit
 - merge: drop 'git merge <message> HEAD <commit>' syntax

 Stop supporting "git merge <message> HEAD <commit>" syntax that has
 been deprecated since October 2007, and issues a deprecation
 warning message since v2.5.0.

 It has been reported that git-gui still uses the deprecated syntax,
 which needs to be fixed before this final step can proceed.
 cf. <5671DB28.8020901@kdbg.org>

--------------------------------------------------
[Discarded]

* jn/fix-connect-unexpected-hangup-diag (2016-09-08) 1 commit
 . connect: tighten check for unexpected early hang up

 Now part of jt/accept-capability-advertisement-when-fetching-from-void
 topic.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: What's cooking in git.git (Sep 2016, #03; Fri, 9)
  2016-09-09 22:47 What's cooking in git.git (Sep 2016, #03; Fri, 9) Junio C Hamano
@ 2016-09-12 16:46 ` Jeff King
  2016-09-12 19:10   ` Junio C Hamano
  0 siblings, 1 reply; 4+ messages in thread
From: Jeff King @ 2016-09-12 16:46 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: git

On Fri, Sep 09, 2016 at 03:47:35PM -0700, Junio C Hamano wrote:

> * jk/delta-base-cache (2016-08-23) 7 commits
>   (merged to 'next' on 2016-08-25 at f1c141a)
>  + t/perf: add basic perf tests for delta base cache
>  + delta_base_cache: use hashmap.h
>  + delta_base_cache: drop special treatment of blobs
>  + delta_base_cache: use list.h for LRU
>  + release_delta_base_cache: reuse existing detach function
>  + clear_delta_base_cache_entry: use a more descriptive name
>  + cache_or_unpack_entry: drop keep_cache parameter
> 
>  The delta-base-cache mechanism has been a key to the performance in
>  a repository with a tightly packed packfile, but it did not scale
>  well even with a larger value of core.deltaBaseCacheLimit.

I happened to notice today that this topic needs a minor tweak:

-- >8 --
Subject: [PATCH] add_delta_base_cache: use list_for_each_safe

We may remove elements from the list while we are iterating,
which requires using a second temporary pointer. Otherwise
stepping to the next element of the list might involve
looking at freed memory (which generally works in practice,
as we _just_ freed it, but of course is wrong to rely on;
valgrind notices it).

Signed-off-by: Jeff King <peff@peff.net>
---
 sha1_file.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sha1_file.c b/sha1_file.c
index a57b71d..132c861 100644
--- a/sha1_file.c
+++ b/sha1_file.c
@@ -2187,11 +2187,11 @@ static void add_delta_base_cache(struct packed_git *p, off_t base_offset,
 	void *base, unsigned long base_size, enum object_type type)
 {
 	struct delta_base_cache_entry *ent = xmalloc(sizeof(*ent));
-	struct list_head *lru;
+	struct list_head *lru, *tmp;
 
 	delta_base_cached += base_size;
 
-	list_for_each(lru, &delta_base_cache_lru) {
+	list_for_each_safe(lru, tmp, &delta_base_cache_lru) {
 		struct delta_base_cache_entry *f =
 			list_entry(lru, struct delta_base_cache_entry, lru);
 		if (delta_base_cached <= delta_base_cache_limit)
-- 
2.10.0.230.g6f8d04b


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: What's cooking in git.git (Sep 2016, #03; Fri, 9)
  2016-09-12 16:46 ` Jeff King
@ 2016-09-12 19:10   ` Junio C Hamano
  2016-09-12 21:46     ` Jeff King
  0 siblings, 1 reply; 4+ messages in thread
From: Junio C Hamano @ 2016-09-12 19:10 UTC (permalink / raw)
  To: Jeff King; +Cc: git

Jeff King <peff@peff.net> writes:

> I happened to notice today that this topic needs a minor tweak:
>
> -- >8 --
> Subject: [PATCH] add_delta_base_cache: use list_for_each_safe
>
> We may remove elements from the list while we are iterating,
> which requires using a second temporary pointer. Otherwise
> stepping to the next element of the list might involve
> looking at freed memory (which generally works in practice,
> as we _just_ freed it, but of course is wrong to rely on;
> valgrind notices it).

I failed to notice it, too.  Thanks.

> Signed-off-by: Jeff King <peff@peff.net>
> ---
>  sha1_file.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sha1_file.c b/sha1_file.c
> index a57b71d..132c861 100644
> --- a/sha1_file.c
> +++ b/sha1_file.c
> @@ -2187,11 +2187,11 @@ static void add_delta_base_cache(struct packed_git *p, off_t base_offset,
>  	void *base, unsigned long base_size, enum object_type type)
>  {
>  	struct delta_base_cache_entry *ent = xmalloc(sizeof(*ent));
> -	struct list_head *lru;
> +	struct list_head *lru, *tmp;
>  
>  	delta_base_cached += base_size;
>  
> -	list_for_each(lru, &delta_base_cache_lru) {
> +	list_for_each_safe(lru, tmp, &delta_base_cache_lru) {
>  		struct delta_base_cache_entry *f =
>  			list_entry(lru, struct delta_base_cache_entry, lru);
>  		if (delta_base_cached <= delta_base_cache_limit)

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: What's cooking in git.git (Sep 2016, #03; Fri, 9)
  2016-09-12 19:10   ` Junio C Hamano
@ 2016-09-12 21:46     ` Jeff King
  0 siblings, 0 replies; 4+ messages in thread
From: Jeff King @ 2016-09-12 21:46 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: git

On Mon, Sep 12, 2016 at 12:10:13PM -0700, Junio C Hamano wrote:

> Jeff King <peff@peff.net> writes:
> 
> > I happened to notice today that this topic needs a minor tweak:
> >
> > -- >8 --
> > Subject: [PATCH] add_delta_base_cache: use list_for_each_safe
> >
> > We may remove elements from the list while we are iterating,
> > which requires using a second temporary pointer. Otherwise
> > stepping to the next element of the list might involve
> > looking at freed memory (which generally works in practice,
> > as we _just_ freed it, but of course is wrong to rely on;
> > valgrind notices it).
> 
> I failed to notice it, too.  Thanks.

After staring at this, I was wondering how the _original_ ever worked.
Because the problem is in the linked-list code, which I did not really
change (I switched it to LIST_HEAD(), but the code is equivalent).

The answer is that in the original, there was no free() in the original
code when we released an entry; it just went back to the (static) pool.

So the bug is in the conversion to hashmap, where we start allocating
(and freeing) the entries individually.

-Peff

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-09-12 21:46 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-09 22:47 What's cooking in git.git (Sep 2016, #03; Fri, 9) Junio C Hamano
2016-09-12 16:46 ` Jeff King
2016-09-12 19:10   ` Junio C Hamano
2016-09-12 21:46     ` Jeff King

Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).