git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jacob Keller <jacob.keller@gmail.com>
Cc: Phillip Wood <phillip.wood@talktalk.net>,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Jacob Keller <jacob.e.keller@intel.com>,
	Git mailing list <git@vger.kernel.org>
Subject: Re: [PATCH] rebase: exec leaks GIT_DIR to environment
Date: Mon, 30 Oct 2017 12:36:51 +0900	[thread overview]
Message-ID: <xmqqo9op71d8.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CA+P7+xrXLcTQpPWgzLwt_yZo=QdfetF36jrc_TtXfqMKR2Hh3w@mail.gmail.com> (Jacob Keller's message of "Sun, 29 Oct 2017 19:53:25 -0700")

Jacob Keller <jacob.keller@gmail.com> writes:

> I am pretty confident we can fix it....

I am sure we can eventually, but 3 hours is not enough soak time.  

I am inclined to leave the fix for 2.15.1/2.16.0 instead of delaying
the release by 10 more days.

  reply	other threads:[~2017-10-30  3:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-28  0:01 [PATCH] rebase: exec leaks GIT_DIR to environment Jacob Keller
2017-10-28 16:00 ` Johannes Schindelin
2017-10-28 22:35   ` Jacob Keller
2017-10-29 18:34   ` Phillip Wood
2017-10-30  2:26     ` Junio C Hamano
2017-10-30  2:53       ` Jacob Keller
2017-10-30  3:36         ` Junio C Hamano [this message]
2017-10-30  6:26           ` Jacob Keller
2017-10-30 10:20             ` Phillip Wood
2017-10-30 12:46               ` Johannes Schindelin
2017-10-31  8:13                 ` Jacob Keller
2017-10-30  2:51     ` Jacob Keller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqo9op71d8.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=jacob.e.keller@intel.com \
    --cc=jacob.keller@gmail.com \
    --cc=phillip.wood@talktalk.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).