git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jacob Keller <jacob.keller@gmail.com>
To: phillip.wood@dunelm.org.uk
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Jacob Keller <jacob.e.keller@intel.com>,
	Git mailing list <git@vger.kernel.org>
Subject: Re: [PATCH] rebase: exec leaks GIT_DIR to environment
Date: Sun, 29 Oct 2017 19:51:14 -0700	[thread overview]
Message-ID: <CA+P7+xrUeM-TsXrbOxscqaqCJB+wq2NP-TdnxzvA7n4vQXvOxQ@mail.gmail.com> (raw)
In-Reply-To: <4150d979-f653-e79b-563a-1dc43f12468d@talktalk.net>

On Sun, Oct 29, 2017 at 11:34 AM, Phillip Wood
<phillip.wood@talktalk.net> wrote:
>
> Just clearing GIT_DIR does not match the behavior of the shell version
> (tested by passing -p to avoid rebase--helper) as that passes GIT_DIR to
> exec commands if it has been explicitly set. I think that users that set
> GIT_DIR on the command line would expect it to be propagated to exec
> commands.
>
> $ git rebase -px'echo $GIT_DIR' @
>
>                                                             Merge commit
> '7c2f1abd64' into phil
> Executing: echo $GIT_DIR
>
> Successfully rebased and updated refs/heads/phil.
>
> $ env GIT_DIR=.git git rebase -px'echo $GIT_DIR' @
>
>                                                             Merge commit
> '7c2f1abd64' into phil
> Executing: echo $GIT_DIR
> /home/phil/Documents/src/git/.git/worktrees/git-next
> Successfully rebased and updated refs/heads/phil.
>

I'm not really sure what the exact fix is, since we do want to pass in
GIT_DIR if it was passed to us, but maybe it needs to be an absolute
path?

Thanks,
Jake

      parent reply	other threads:[~2017-10-30  2:51 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-28  0:01 [PATCH] rebase: exec leaks GIT_DIR to environment Jacob Keller
2017-10-28 16:00 ` Johannes Schindelin
2017-10-28 22:35   ` Jacob Keller
2017-10-29 18:34   ` Phillip Wood
2017-10-30  2:26     ` Junio C Hamano
2017-10-30  2:53       ` Jacob Keller
2017-10-30  3:36         ` Junio C Hamano
2017-10-30  6:26           ` Jacob Keller
2017-10-30 10:20             ` Phillip Wood
2017-10-30 12:46               ` Johannes Schindelin
2017-10-31  8:13                 ` Jacob Keller
2017-10-30  2:51     ` Jacob Keller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+P7+xrUeM-TsXrbOxscqaqCJB+wq2NP-TdnxzvA7n4vQXvOxQ@mail.gmail.com \
    --to=jacob.keller@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=jacob.e.keller@intel.com \
    --cc=phillip.wood@dunelm.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).