From: Junio C Hamano <gitster@pobox.com>
To: "Jan “Khardix” Staněk" <khardix@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: git-send-email: smtpserver in $HOME
Date: Mon, 15 Feb 2021 18:14:39 -0800 [thread overview]
Message-ID: <xmqqo8gksqr4.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <CAG+K25Pk0+sOAYuWS2OF7CXLXJLjGMKyBB_SOLpoO5RFiktN5g@mail.gmail.com> ("Jan “Khardix” Staněk"'s message of "Mon, 15 Feb 2021 06:07:30 -0800")
Jan “Khardix” Staněk <khardix@gmail.com> writes:
> Would it be feasible to treat the `smtpserver` as path option
> and expand `~`/`~user` paths?
> Would it break anything
> (i.e., is `~` a valid character for beginning of a hostname)?
I haven't given too much thought, but offhand do not think of a
reason why a change like the attached would break things.
git-send-email.perl | 2 ++
1 file changed, 2 insertions(+)
diff --git c/git-send-email.perl w/git-send-email.perl
index 1f425c0809..ff58ac5046 100755
--- c/git-send-email.perl
+++ w/git-send-email.perl
@@ -1006,6 +1006,8 @@ sub expand_one_alias {
}
}
$smtp_server ||= 'localhost'; # could be 127.0.0.1, too... *shrug*
+} elsif ($smtp_server =~ /^~/) {
+ $smtp_server = glob($smtp_server);
}
if ($compose && $compose > 0) {
next prev parent reply other threads:[~2021-02-16 2:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-15 14:07 git-send-email: smtpserver in $HOME Jan “Khardix” Staněk
2021-02-16 2:14 ` Junio C Hamano [this message]
2021-02-16 12:49 ` Jan “Khardix” Staněk
2021-02-16 18:53 ` Junio C Hamano
2021-02-16 22:14 ` Jan “Khardix” Staněk
2021-02-18 10:18 ` Chris Torek
2021-02-18 12:57 ` Andreas Schwab
2021-02-16 15:45 ` Jeff King
2021-02-16 18:57 ` Junio C Hamano
2021-02-16 19:05 ` Jeff King
2021-02-16 19:16 ` Junio C Hamano
2021-02-16 19:23 ` Jeff King
2021-02-16 22:31 ` Jan “Khardix” Staněk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqo8gksqr4.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=khardix@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).