From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Jan “Khardix” Staněk" <khardix@gmail.com>, git@vger.kernel.org
Subject: Re: git-send-email: smtpserver in $HOME
Date: Tue, 16 Feb 2021 10:45:57 -0500 [thread overview]
Message-ID: <YCvotU6KVruFuf9/@coredump.intra.peff.net> (raw)
In-Reply-To: <xmqqo8gksqr4.fsf@gitster.c.googlers.com>
On Mon, Feb 15, 2021 at 06:14:39PM -0800, Junio C Hamano wrote:
> Jan “Khardix” Staněk <khardix@gmail.com> writes:
>
> > Would it be feasible to treat the `smtpserver` as path option
> > and expand `~`/`~user` paths?
> > Would it break anything
> > (i.e., is `~` a valid character for beginning of a hostname)?
>
> I haven't given too much thought, but offhand do not think of a
> reason why a change like the attached would break things.
I agree it's unlikely to break anything.
Still, it seems a bit unusual for an executed program to handle tilde
like this. The usual mechanism is for us to run it with the shell and
expect to find it in $PATH.
It looks like there's some weirdness here, though; $smtp_server may be a
hostname, and it looks like we use "/" to distinguish a file path. I
wonder if allowing "!my-sendmail" would be more consistent with other
parts of Git (not to mention more flexible).
-Peff
next prev parent reply other threads:[~2021-02-16 15:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-15 14:07 git-send-email: smtpserver in $HOME Jan “Khardix” Staněk
2021-02-16 2:14 ` Junio C Hamano
2021-02-16 12:49 ` Jan “Khardix” Staněk
2021-02-16 18:53 ` Junio C Hamano
2021-02-16 22:14 ` Jan “Khardix” Staněk
2021-02-18 10:18 ` Chris Torek
2021-02-18 12:57 ` Andreas Schwab
2021-02-16 15:45 ` Jeff King [this message]
2021-02-16 18:57 ` Junio C Hamano
2021-02-16 19:05 ` Jeff King
2021-02-16 19:16 ` Junio C Hamano
2021-02-16 19:23 ` Jeff King
2021-02-16 22:31 ` Jan “Khardix” Staněk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCvotU6KVruFuf9/@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=khardix@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).