From: Junio C Hamano <gitster@pobox.com>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: Piotr Krukowiecki <piotr.krukowiecki@gmail.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: git grep: search whole tree by default?
Date: Wed, 23 Oct 2013 10:23:54 -0700 [thread overview]
Message-ID: <xmqqmwlzrjdh.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <vpqbo2guff7.fsf@anie.imag.fr> (Matthieu Moy's message of "Wed, 23 Oct 2013 18:21:00 +0200")
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
> In summary: changing is painful. The case of "git add" was really bad,
> since the same command had different behavior depending on the options
> given, so it was clearly worth the pain. In the case of "git grep", the
> current behavior is not _that_ bad, so nobody bothered to do the change.
>
> (by "do the change", I mean propose a migration plan, convince people
> that it is good, ...)
>
> I'd personally be slightly in favor of changing to tree-wide, but
> without strong opinion.
After reading that old thread again, I tend to think that the only
reason to favor "git grep" to start at the $(cwd) is the backward
compatibility. While I do expect that many people will be annoyed
when "git grep" (no pathspecs) that is run in a subdirectory starts
spitting out a large number of hits from places irrelevant for the
current task at hand, hits from outside the $(cwd) is something they
can _notice_ easily and their fingers will quickly learn to add "."
without even thinking.
I suspect that it would be too late for 2.0 we want to do sometime
early next year, though.
next prev parent reply other threads:[~2013-10-23 17:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-23 8:25 git grep: search whole tree by default? Piotr Krukowiecki
2013-10-23 16:21 ` Matthieu Moy
2013-10-23 17:23 ` Junio C Hamano [this message]
2013-10-23 18:20 ` Jed Brown
2013-10-23 18:52 ` Junio C Hamano
2013-10-23 19:24 ` Jed Brown
2013-10-23 19:31 ` Junio C Hamano
2013-10-24 2:15 ` David Aguilar
2013-10-23 20:43 ` Matthieu Moy
2013-10-24 2:27 ` Jeff King
2013-10-24 19:40 ` Junio C Hamano
2013-10-25 2:23 ` David Aguilar
2013-10-25 4:37 ` Jeff King
2013-10-25 4:52 ` Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmwlzrjdh.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=piotr.krukowiecki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).