git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Per Cederqvist <cederp@opera.com>
Cc: git@vger.kernel.org
Subject: Re: git log: invert --author and --committer
Date: Mon, 23 May 2016 10:11:16 -0700	[thread overview]
Message-ID: <xmqqmvngaedn.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CAP=KgsSdX3pCRzeUVobrFWVGOGGSrwkO0MjFhUWruiajAxn38Q@mail.gmail.com> (Per Cederqvist's message of "Mon, 23 May 2016 11:54:45 +0200")

Per Cederqvist <cederp@opera.com> writes:

> We have a repository that mostly contains configuration data.
> This is updated by our continuous integration build system, but
> every once in a while there are also more interesting commits
> made by humans.
>
> For several years I have suffered in silence, wishing for a way
> to do something like
>
>     git log --author-not cibot
>
> Today a friend told me that you can actually list all commits
> except those made by cibot with this commandline:
>
>     git log --invert-grep --author cibot
>
> The documentation for --invert-grep should mention that it
> also inverts the meaning of --author and --committer.  Perphaps
> something like this would make sense?
>
>     /ceder

Yeah, the author/committer search piggy-backs the more generic "grep
in the log" machinery, but it is quite hidden and the document
failed to tell the end users that is what is going on.  Mentioning
that invert (or any tweak that works on the grep machinery) affects
author/committer search is a good idea.

Does "-i/--regexp-ignore-case" also need the same treatment?

> diff --git a/Documentation/rev-list-options.txt
> b/Documentation/rev-list-options.txt
> index 4f009d4..ae12687 100644
> --- a/Documentation/rev-list-options.txt
> +++ b/Documentation/rev-list-options.txt
> @@ -70,7 +70,8 @@ endif::git-rev-list[]
>
>  --invert-grep::
>   Limit the commits output to ones with log message that do not
> - match the pattern specified with `--grep=<pattern>`.
> + match the pattern specified with `--grep=<pattern>`.  Also
> + affects `--author=<pattern>` and `--committer=<pattern>`.
>
>  -i::
>  --regexp-ignore-case::

  reply	other threads:[~2016-05-23 17:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-23  9:54 git log: invert --author and --committer Per Cederqvist
2016-05-23 17:11 ` Junio C Hamano [this message]
2016-05-23 19:26   ` Junio C Hamano
2016-05-23 21:21     ` Per Cederqvist
2016-05-23 21:26       ` Junio C Hamano
2016-05-23 21:47       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqmvngaedn.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=cederp@opera.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).