From: Junio C Hamano <gitster@pobox.com>
To: Per Cederqvist <cederp@opera.com>
Cc: git@vger.kernel.org
Subject: Re: git log: invert --author and --committer
Date: Mon, 23 May 2016 12:26:05 -0700 [thread overview]
Message-ID: <xmqq37p8a84y.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <xmqqmvngaedn.fsf@gitster.mtv.corp.google.com> (Junio C. Hamano's message of "Mon, 23 May 2016 10:11:16 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> Per Cederqvist <cederp@opera.com> writes:
>
>> git log --invert-grep --author cibot
>...
> Yeah, the author/committer search piggy-backs the more generic "grep
> in the log" machinery, but it is quite hidden and the document
> failed to tell the end users that is what is going on. Mentioning
> that invert (or any tweak that works on the grep machinery) affects
> author/committer search is a good idea.
>
> Does "-i/--regexp-ignore-case" also need the same treatment?
It seems it does.
How about making this clarification not about --invert-grep but
about --committer/--author option, perhaps like this?
Documentation/rev-list-options.txt | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/rev-list-options.txt b/Documentation/rev-list-options.txt
index 4f009d4..3fca366 100644
--- a/Documentation/rev-list-options.txt
+++ b/Documentation/rev-list-options.txt
@@ -44,6 +44,10 @@ endif::git-rev-list[]
expression). With more than one `--author=<pattern>`,
commits whose author matches any of the given patterns are
chosen (similarly for multiple `--committer=<pattern>`).
++
+Options that affect how a regular expression match is performed
+(such as `-i`, `-E`, `--invert-grep`) can also be used affect these
+options.
--grep-reflog=<pattern>::
Limit the commits output to ones with reflog entries that
next prev parent reply other threads:[~2016-05-23 19:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-23 9:54 git log: invert --author and --committer Per Cederqvist
2016-05-23 17:11 ` Junio C Hamano
2016-05-23 19:26 ` Junio C Hamano [this message]
2016-05-23 21:21 ` Per Cederqvist
2016-05-23 21:26 ` Junio C Hamano
2016-05-23 21:47 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq37p8a84y.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=cederp@opera.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).