From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Taylor Blau <me@ttaylorr.com>, git@vger.kernel.org, peff@peff.net
Subject: Re: [PATCH v2] ref-filter.c: pass empty-string as NULL to atom parsers
Date: Tue, 03 Oct 2017 08:55:01 +0900 [thread overview]
Message-ID: <xmqqmv59m7fu.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20171002224052.GR19555@aiede.mtv.corp.google.com> (Jonathan Nieder's message of "Mon, 2 Oct 2017 15:40:52 -0700")
Jonathan Nieder <jrnieder@gmail.com> writes:
> The above does a nice job of explaining
>
> - what this change is going to do
> - how it's good for the internal code structure / maintainability
>
> What it doesn't tell me about is why the user-facing effect won't
> cause problems. Is there no atom where %(atom:) was previously
> accepted and did something meaningful that this may break?
That is, was there any situation where %(atom) and %(atom:) did two
differnt things and their differences made sense?
> Looking at the manpage and code, I don't see any, so for what it's
> worth, this is
>
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
>
> but for next time, please remember to discuss regression risk in
> the commit message, too.
Yes, I agree that it is necessary to make sure somebody looked at
the issue _and_ record the fact that it happened. Thanks for doing
that already ;-)
I also took a look at the code and currently we seem to abort,
either with "unrecognised arg" (e.g. "refname:") or "does not take
args" (e.g. "body"), so we should be OK, I'd think.
next prev parent reply other threads:[~2017-10-02 23:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-02 5:50 [PATCH 0/1] ref-filter.c: pass empty-string as NULL to atom parsers Taylor Blau
2017-10-02 5:53 ` [PATCH] " Taylor Blau
2017-10-02 6:43 ` Jeff King
2017-10-02 16:12 ` Taylor Blau
2017-10-02 19:42 ` Jeff King
2017-10-02 16:10 ` [PATCH v2] " Taylor Blau
2017-10-02 19:42 ` Jeff King
2017-10-02 22:40 ` Jonathan Nieder
2017-10-02 23:55 ` Junio C Hamano [this message]
2017-10-03 3:37 ` Taylor Blau
2017-10-05 1:49 ` Junio C Hamano
2017-10-05 2:11 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmv59m7fu.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).