From: Jonathan Nieder <jrnieder@gmail.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: git@vger.kernel.org, gitster@pobox.com, peff@peff.net
Subject: Re: [PATCH v2] ref-filter.c: pass empty-string as NULL to atom parsers
Date: Mon, 2 Oct 2017 15:40:52 -0700 [thread overview]
Message-ID: <20171002224052.GR19555@aiede.mtv.corp.google.com> (raw)
In-Reply-To: <20171002161034.44867-1-me@ttaylorr.com>
Hi,
Taylor Blau wrote:
> Peff points out that different atom parsers handle the empty
> "sub-argument" list differently. An example of this is the format
> "%(refname:)".
>
> Since callers often use `string_list_split` (which splits the empty
> string with any delimiter as a 1-ary string_list containing the empty
> string), this makes handling empty sub-argument strings non-ergonomic.
>
> Let's fix this by assuming that atom parser implementations don't care
> about distinguishing between the empty string "%(refname:)" and no
> sub-arguments "%(refname)".
>
> Signed-off-by: Taylor Blau <me@ttaylorr.com>
> ---
> ref-filter.c | 10 +++++++++-
> t/t6300-for-each-ref.sh | 1 +
> 2 files changed, 10 insertions(+), 1 deletion(-)
The above does a nice job of explaining
- what this change is going to do
- how it's good for the internal code structure / maintainability
What it doesn't tell me about is why the user-facing effect won't
cause problems. Is there no atom where %(atom:) was previously
accepted and did something meaningful that this may break?
Looking at the manpage and code, I don't see any, so for what it's
worth, this is
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
but for next time, please remember to discuss regression risk in
the commit message, too.
Thanks,
Jonathan
next prev parent reply other threads:[~2017-10-02 22:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-02 5:50 [PATCH 0/1] ref-filter.c: pass empty-string as NULL to atom parsers Taylor Blau
2017-10-02 5:53 ` [PATCH] " Taylor Blau
2017-10-02 6:43 ` Jeff King
2017-10-02 16:12 ` Taylor Blau
2017-10-02 19:42 ` Jeff King
2017-10-02 16:10 ` [PATCH v2] " Taylor Blau
2017-10-02 19:42 ` Jeff King
2017-10-02 22:40 ` Jonathan Nieder [this message]
2017-10-02 23:55 ` Junio C Hamano
2017-10-03 3:37 ` Taylor Blau
2017-10-05 1:49 ` Junio C Hamano
2017-10-05 2:11 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171002224052.GR19555@aiede.mtv.corp.google.com \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).