From: Junio C Hamano <gitster@pobox.com>
To: Robert Stanca <robert.stanca7@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/2] [GSOC] show_bisect_vars(): Use unsigned int instead of signed int for flags
Date: Sat, 01 Apr 2017 20:30:22 -0700 [thread overview]
Message-ID: <xmqqlgrjtrjl.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CAJYcaSNAB+1gth2NkTjrcBV9TXT9bRsBQhwOsQCmnudYz5bTmg@mail.gmail.com> (Robert Stanca's message of "Sat, 1 Apr 2017 22:19:26 +0300")
Robert Stanca <robert.stanca7@gmail.com> writes:
> I am used to 1change per patch so it's easier to redo specific
> patches...if there are small changes(10 lines max) can i send them as
> 1 patch?
It's not number of lines. One line per patch does not make sense if
you need to make corresponding changes to two places, one line each,
in order to make the end result consistent. If you change a type of
a structure field, and that field is assigned to a variable
somewhere, you would change the type of both that field and the
variable that receives its value at the same time in a single
commit, as that would be the logical unit of a smallest change that
still makes sense (i.e. either half of that change alone would not
make sense).
next prev parent reply other threads:[~2017-04-02 3:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-01 15:30 [PATCH 1/2] [GSOC] Convert signed flags to unsigned Robert Stanca
2017-04-01 15:30 ` [PATCH 2/2] [GSOC] show_bisect_vars(): Use unsigned int instead of signed int for flags Robert Stanca
2017-04-01 19:13 ` Junio C Hamano
2017-04-01 19:19 ` Robert Stanca
2017-04-02 3:30 ` Junio C Hamano [this message]
2017-04-02 13:18 ` Robert Stanca
2017-04-02 17:14 ` Junio C Hamano
2017-04-01 19:12 ` [PATCH 1/2] [GSOC] Convert signed flags to unsigned Junio C Hamano
2017-04-01 19:30 ` Robert Stanca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqlgrjtrjl.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=robert.stanca7@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).