From: Robert Stanca <robert.stanca7@gmail.com>
To: git@vger.kernel.org
Cc: Robert Stanca <robert.stanca7@gmail.com>
Subject: [PATCH 1/2] [GSOC] Convert signed flags to unsigned
Date: Sat, 1 Apr 2017 18:30:48 +0300 [thread overview]
Message-ID: <20170401153049.21400-1-robert.stanca7@gmail.com> (raw)
Unsigned int is a closer representation of bitflags rather than signed int that uses 1 special bit for sign.This shouldn't make much difference because rev_list_info.flags uses only 2 bits(BISECT_SHOW_ALL and REV_LIST_QUIET)
Signed-off-by: Robert Stanca <robert.stanca7@gmail.com>
---
bisect.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/bisect.h b/bisect.h
index acd12ef80..a979a7f11 100644
--- a/bisect.h
+++ b/bisect.h
@@ -16,7 +16,7 @@ extern struct commit_list *filter_skipped(struct commit_list *list,
struct rev_list_info {
struct rev_info *revs;
- int flags;
+ unsigned int flags;
int show_timestamp;
int hdr_termination;
const char *header_prefix;
--
2.12.2.575.gb14f27f91.dirty
next reply other threads:[~2017-04-01 15:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-01 15:30 Robert Stanca [this message]
2017-04-01 15:30 ` [PATCH 2/2] [GSOC] show_bisect_vars(): Use unsigned int instead of signed int for flags Robert Stanca
2017-04-01 19:13 ` Junio C Hamano
2017-04-01 19:19 ` Robert Stanca
2017-04-02 3:30 ` Junio C Hamano
2017-04-02 13:18 ` Robert Stanca
2017-04-02 17:14 ` Junio C Hamano
2017-04-01 19:12 ` [PATCH 1/2] [GSOC] Convert signed flags to unsigned Junio C Hamano
2017-04-01 19:30 ` Robert Stanca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170401153049.21400-1-robert.stanca7@gmail.com \
--to=robert.stanca7@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).