From: Junio C Hamano <gitster@pobox.com>
To: Stefan Beller <sbeller@google.com>
Cc: git@vger.kernel.org, jrnieder@gmail.com, git@jeffhostetler.com
Subject: Re: [PATCHv2 1/2] hashmap.h: compare function has access to a data field
Date: Fri, 30 Jun 2017 10:34:01 -0700 [thread overview]
Message-ID: <xmqqlgo9s7li.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170629235336.28460-2-sbeller@google.com> (Stefan Beller's message of "Thu, 29 Jun 2017 16:53:35 -0700")
Stefan Beller <sbeller@google.com> writes:
> When using the hashmap a common need is to have access to arbitrary data
> in the compare function. A couple of times we abuse the keydata field
> to pass in the data needed. This happens for example in patch-ids.c.
It is not "arbitrary data"; it is very important to streess that we
are not just passing random crud, but adding a mechanism to
tailor/curry the function in a way that is fixed throughout the
lifetime of a hashmap.
> diff --git a/hashmap.h b/hashmap.h
> index de6022a3a9..1c26bbad5b 100644
> --- a/hashmap.h
> +++ b/hashmap.h
> @@ -33,11 +33,12 @@ struct hashmap_entry {
> };
>
> typedef int (*hashmap_cmp_fn)(const void *entry, const void *entry_or_key,
> - const void *keydata);
> + const void *keydata, const void *cbdata);
As I view the new "data" thing the C's (read: poor-man's) way to
cutomize the function, I would have tweaked the function signature
by giving the customization data at the front, i.e.
fn(fndata, entry, entry_or_key, keydata);
That would hopefully make it more obvious that the new thing is
pairs with fn, not with other arguments (and entry-or-key and
keydata pairs, instead of three old arguments standing as equals).
As I think the way we wish to be able to express it in a better
language would have been something like:
(partial_apply(fn, fndata))(entry, entry_or_key, keydata)
that order would match what is going on better.
next prev parent reply other threads:[~2017-06-30 17:34 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-29 1:13 [PATCH 0/2] Introduce data field in hashmap and migrate docs to header Stefan Beller
2017-06-29 1:13 ` [PATCH 1/2] hashmap.h: compare function has access to a data field Stefan Beller
2017-06-29 18:06 ` Junio C Hamano
2017-06-29 18:11 ` Junio C Hamano
2017-06-29 18:20 ` Stefan Beller
2017-06-30 17:26 ` Junio C Hamano
2017-06-29 1:13 ` [PATCH 2/2] hashmap: migrate documentation from Documentation/technical into header Stefan Beller
2017-06-29 13:25 ` Jeff Hostetler
2017-06-29 21:18 ` Jonathan Nieder
2017-06-29 23:41 ` Stefan Beller
2017-06-29 23:53 ` [PATCHv2 0/2] Introduce data field in hashmap and migrate docs to header Stefan Beller
2017-06-29 23:53 ` [PATCHv2 1/2] hashmap.h: compare function has access to a data field Stefan Beller
2017-06-30 17:34 ` Junio C Hamano [this message]
2017-06-30 17:41 ` Stefan Beller
2017-06-30 18:47 ` Junio C Hamano
2017-06-30 18:57 ` Stefan Beller
2017-06-30 17:39 ` Junio C Hamano
2017-06-30 18:00 ` Stefan Beller
2017-06-30 18:40 ` Junio C Hamano
2017-06-29 23:53 ` [PATCHv2 2/2] hashmap: migrate documentation from Documentation/technical into header Stefan Beller
2017-06-30 19:14 ` [PATCHv3 0/3] Introduce data field in hashmap and migrate docs to header Stefan Beller
2017-06-30 19:14 ` [PATCHv3 1/3] hashmap.h: compare function has access to a data field Stefan Beller
2017-06-30 19:14 ` [PATCHv3 2/3] patch-ids.c: use hashmap correctly Stefan Beller
2017-06-30 19:50 ` Junio C Hamano
2017-07-05 9:00 ` Jeff King
2017-06-30 19:14 ` [PATCHv3 3/3] hashmap: migrate documentation from Documentation/technical into header Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqlgo9s7li.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).