From: Jeff Hostetler <git@jeffhostetler.com>
To: Stefan Beller <sbeller@google.com>, gitster@pobox.com
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/2] hashmap: migrate documentation from Documentation/technical into header
Date: Thu, 29 Jun 2017 09:25:07 -0400 [thread overview]
Message-ID: <0749bca3-a2b7-7314-b9fb-2217390b919e@jeffhostetler.com> (raw)
In-Reply-To: <20170629011334.11173-3-sbeller@google.com>
On 6/28/2017 9:13 PM, Stefan Beller wrote:
> While at it, clarify the use of `key`, `keydata`, `entry_or_key` as well
> as documenting the new data pointer for the compare function.
>
> Signed-off-by: Stefan Beller <sbeller@google.com>
> ---
> Documentation/technical/api-hashmap.txt | 309 --------------------------------
> hashmap.h | 249 +++++++++++++++++++++++--
> 2 files changed, 231 insertions(+), 327 deletions(-)
> delete mode 100644 Documentation/technical/api-hashmap.txt
> ...
This looks very nice. Thank you!
Jeff
next prev parent reply other threads:[~2017-06-29 13:25 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-29 1:13 [PATCH 0/2] Introduce data field in hashmap and migrate docs to header Stefan Beller
2017-06-29 1:13 ` [PATCH 1/2] hashmap.h: compare function has access to a data field Stefan Beller
2017-06-29 18:06 ` Junio C Hamano
2017-06-29 18:11 ` Junio C Hamano
2017-06-29 18:20 ` Stefan Beller
2017-06-30 17:26 ` Junio C Hamano
2017-06-29 1:13 ` [PATCH 2/2] hashmap: migrate documentation from Documentation/technical into header Stefan Beller
2017-06-29 13:25 ` Jeff Hostetler [this message]
2017-06-29 21:18 ` Jonathan Nieder
2017-06-29 23:41 ` Stefan Beller
2017-06-29 23:53 ` [PATCHv2 0/2] Introduce data field in hashmap and migrate docs to header Stefan Beller
2017-06-29 23:53 ` [PATCHv2 1/2] hashmap.h: compare function has access to a data field Stefan Beller
2017-06-30 17:34 ` Junio C Hamano
2017-06-30 17:41 ` Stefan Beller
2017-06-30 18:47 ` Junio C Hamano
2017-06-30 18:57 ` Stefan Beller
2017-06-30 17:39 ` Junio C Hamano
2017-06-30 18:00 ` Stefan Beller
2017-06-30 18:40 ` Junio C Hamano
2017-06-29 23:53 ` [PATCHv2 2/2] hashmap: migrate documentation from Documentation/technical into header Stefan Beller
2017-06-30 19:14 ` [PATCHv3 0/3] Introduce data field in hashmap and migrate docs to header Stefan Beller
2017-06-30 19:14 ` [PATCHv3 1/3] hashmap.h: compare function has access to a data field Stefan Beller
2017-06-30 19:14 ` [PATCHv3 2/3] patch-ids.c: use hashmap correctly Stefan Beller
2017-06-30 19:50 ` Junio C Hamano
2017-07-05 9:00 ` Jeff King
2017-06-30 19:14 ` [PATCHv3 3/3] hashmap: migrate documentation from Documentation/technical into header Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0749bca3-a2b7-7314-b9fb-2217390b919e@jeffhostetler.com \
--to=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).