* [PATCH] builtin/add: add a missing newline to an stderr message
@ 2017-08-08 21:36 Ramsay Jones
2017-08-08 21:45 ` René Scharfe
2017-08-08 22:34 ` Jonathan Nieder
0 siblings, 2 replies; 7+ messages in thread
From: Ramsay Jones @ 2017-08-08 21:36 UTC (permalink / raw)
To: Junio C Hamano; +Cc: GIT Mailing-list, René Scharfe
Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---
Hi Junio,
I noticed this while looking into the t3700 failure on cygwin tonight.
Also, I couldn't decide whether or not to add the i18n '_()' brackets
around the message. In the end I didn't, but will happily add them
if you think I should.
Thanks!
ATB,
Ramsay Jones
builtin/add.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/add.c b/builtin/add.c
index e888fb8c5..385b53ae7 100644
--- a/builtin/add.c
+++ b/builtin/add.c
@@ -43,7 +43,7 @@ static void chmod_pathspec(struct pathspec *pathspec, int force_mode)
continue;
if (chmod_cache_entry(ce, force_mode) < 0)
- fprintf(stderr, "cannot chmod '%s'", ce->name);
+ fprintf(stderr, "cannot chmod '%s'\n", ce->name);
}
}
--
2.14.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] builtin/add: add a missing newline to an stderr message
2017-08-08 21:36 [PATCH] builtin/add: add a missing newline to an stderr message Ramsay Jones
@ 2017-08-08 21:45 ` René Scharfe
2017-08-08 22:14 ` Junio C Hamano
2017-08-08 23:55 ` Ramsay Jones
2017-08-08 22:34 ` Jonathan Nieder
1 sibling, 2 replies; 7+ messages in thread
From: René Scharfe @ 2017-08-08 21:45 UTC (permalink / raw)
To: Ramsay Jones, Junio C Hamano; +Cc: GIT Mailing-list
Am 08.08.2017 um 23:36 schrieb Ramsay Jones:
>
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>
> Hi Junio,
>
> I noticed this while looking into the t3700 failure on cygwin tonight.
> Also, I couldn't decide whether or not to add the i18n '_()' brackets
> around the message. In the end I didn't, but will happily add them
> if you think I should.
>
> Thanks!
>
> ATB,
> Ramsay Jones
>
> builtin/add.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/add.c b/builtin/add.c
> index e888fb8c5..385b53ae7 100644
> --- a/builtin/add.c
> +++ b/builtin/add.c
> @@ -43,7 +43,7 @@ static void chmod_pathspec(struct pathspec *pathspec, int force_mode)
> continue;
>
> if (chmod_cache_entry(ce, force_mode) < 0)
> - fprintf(stderr, "cannot chmod '%s'", ce->name);
> + fprintf(stderr, "cannot chmod '%s'\n", ce->name);
> }
> }
>
FYI: I brought this up yesterday in the original thread, along with a
few other observations:
https://public-inbox.org/git/3c61d9f6-e0fd-22a4-68e0-89fd9ce9b944@web.de/
Not sure if the discussion can or should be revived after all this
time, though; just sending patches like yours might be the way to go.
René
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] builtin/add: add a missing newline to an stderr message
2017-08-08 21:45 ` René Scharfe
@ 2017-08-08 22:14 ` Junio C Hamano
2017-08-08 22:34 ` Jonathan Nieder
2017-08-08 23:55 ` Ramsay Jones
1 sibling, 1 reply; 7+ messages in thread
From: Junio C Hamano @ 2017-08-08 22:14 UTC (permalink / raw)
To: René Scharfe; +Cc: Ramsay Jones, GIT Mailing-list
René Scharfe <l.s.r@web.de> writes:
>> diff --git a/builtin/add.c b/builtin/add.c
>> index e888fb8c5..385b53ae7 100644
>> --- a/builtin/add.c
>> +++ b/builtin/add.c
>> @@ -43,7 +43,7 @@ static void chmod_pathspec(struct pathspec *pathspec, int force_mode)
>> continue;
>>
>> if (chmod_cache_entry(ce, force_mode) < 0)
>> - fprintf(stderr, "cannot chmod '%s'", ce->name);
>> + fprintf(stderr, "cannot chmod '%s'\n", ce->name);
>> }
>> }
>
> FYI: I brought this up yesterday in the original thread, along with a
> few other observations:
>
> https://public-inbox.org/git/3c61d9f6-e0fd-22a4-68e0-89fd9ce9b944@web.de/
>
> Not sure if the discussion can or should be revived after all this
> time, though; just sending patches like yours might be the way to go.
Thanks, so it should become
fprintf(stderr, "cannot chmod %c '%s'\n", force_mode, ce->name);
in the final version to be queued?
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] builtin/add: add a missing newline to an stderr message
2017-08-08 22:14 ` Junio C Hamano
@ 2017-08-08 22:34 ` Jonathan Nieder
2017-08-09 5:37 ` Junio C Hamano
0 siblings, 1 reply; 7+ messages in thread
From: Jonathan Nieder @ 2017-08-08 22:34 UTC (permalink / raw)
To: Junio C Hamano; +Cc: René Scharfe, Ramsay Jones, GIT Mailing-list
Junio C Hamano wrote:
> René Scharfe <l.s.r@web.de> writes:
>>> diff --git a/builtin/add.c b/builtin/add.c
>>> index e888fb8c5..385b53ae7 100644
>>> --- a/builtin/add.c
>>> +++ b/builtin/add.c
>>> @@ -43,7 +43,7 @@ static void chmod_pathspec(struct pathspec *pathspec, int force_mode)
>>> continue;
>>>
>>> if (chmod_cache_entry(ce, force_mode) < 0)
>>> - fprintf(stderr, "cannot chmod '%s'", ce->name);
>>> + fprintf(stderr, "cannot chmod '%s'\n", ce->name);
>>> }
>>> }
>>
>> FYI: I brought this up yesterday in the original thread, along with a
>> few other observations:
>>
>> https://public-inbox.org/git/3c61d9f6-e0fd-22a4-68e0-89fd9ce9b944@web.de/
>>
>> Not sure if the discussion can or should be revived after all this
>> time, though; just sending patches like yours might be the way to go.
>
> Thanks, so it should become
>
> fprintf(stderr, "cannot chmod %c '%s'\n", force_mode, ce->name);
>
> in the final version to be queued?
I don't believe the force_mode without an 'x' provides a clear signal
to the end user. Perhaps you meant %cx?
Thanks,
Jonathan
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] builtin/add: add a missing newline to an stderr message
2017-08-08 21:45 ` René Scharfe
2017-08-08 22:14 ` Junio C Hamano
@ 2017-08-08 23:55 ` Ramsay Jones
1 sibling, 0 replies; 7+ messages in thread
From: Ramsay Jones @ 2017-08-08 23:55 UTC (permalink / raw)
To: René Scharfe, Junio C Hamano; +Cc: GIT Mailing-list
On 08/08/17 22:45, René Scharfe wrote:
> Am 08.08.2017 um 23:36 schrieb Ramsay Jones:
>>
>> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
>> ---
>>
>> Hi Junio,
>>
>> I noticed this while looking into the t3700 failure on cygwin tonight.
>> Also, I couldn't decide whether or not to add the i18n '_()' brackets
>> around the message. In the end I didn't, but will happily add them
>> if you think I should.
>>
>> Thanks!
>>
>> ATB,
>> Ramsay Jones
>>
>> builtin/add.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/builtin/add.c b/builtin/add.c
>> index e888fb8c5..385b53ae7 100644
>> --- a/builtin/add.c
>> +++ b/builtin/add.c
>> @@ -43,7 +43,7 @@ static void chmod_pathspec(struct pathspec *pathspec, int force_mode)
>> continue;
>>
>> if (chmod_cache_entry(ce, force_mode) < 0)
>> - fprintf(stderr, "cannot chmod '%s'", ce->name);
>> + fprintf(stderr, "cannot chmod '%s'\n", ce->name);
>> }
>> }
>>
>
> FYI: I brought this up yesterday in the original thread, along with a
> few other observations:
>
> https://public-inbox.org/git/3c61d9f6-e0fd-22a4-68e0-89fd9ce9b944@web.de/
Ah, I missed that.
Hmm, I just looked at the code in builtin/update-index.c. Yes, it
would probably be a good idea to harmonize the messages - but just
where did 'flip' come from? ;-)
ATB,
Ramsay Jones
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] builtin/add: add a missing newline to an stderr message
2017-08-08 21:36 [PATCH] builtin/add: add a missing newline to an stderr message Ramsay Jones
2017-08-08 21:45 ` René Scharfe
@ 2017-08-08 22:34 ` Jonathan Nieder
1 sibling, 0 replies; 7+ messages in thread
From: Jonathan Nieder @ 2017-08-08 22:34 UTC (permalink / raw)
To: Ramsay Jones; +Cc: Junio C Hamano, GIT Mailing-list, René Scharfe
Ramsay Jones wrote:
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Thanks for catching it.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-08-09 5:37 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-08 21:36 [PATCH] builtin/add: add a missing newline to an stderr message Ramsay Jones
2017-08-08 21:45 ` René Scharfe
2017-08-08 22:14 ` Junio C Hamano
2017-08-08 22:34 ` Jonathan Nieder
2017-08-09 5:37 ` Junio C Hamano
2017-08-08 23:55 ` Ramsay Jones
2017-08-08 22:34 ` Jonathan Nieder
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).