From: Junio C Hamano <gitster@pobox.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Lucas Werkmeister <mail@lucaswerkmeister.de>,
Git List <git@vger.kernel.org>
Subject: Re: [PATCH v4] daemon: add --log-destination=(stderr|syslog|none)
Date: Mon, 05 Feb 2018 10:31:34 -0800 [thread overview]
Message-ID: <xmqqlgg7b855.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <CAPig+cSOH-V9aZDALOEX56ENXChexOVWzsgKgtvDULryqP0Kyw@mail.gmail.com> (Eric Sunshine's message of "Sun, 4 Feb 2018 14:36:14 -0500")
Eric Sunshine <sunshine@sunshineco.com> writes:
> On Sun, Feb 4, 2018 at 1:30 PM, Lucas Werkmeister
> <mail@lucaswerkmeister.de> wrote:
>> This new option can be used to override the implicit --syslog of
>> ...
> Thanks. With the 'log_destination' initialization bug fixed, this
> version looks good; I didn't find anything else worth commenting upon.
> Ævar's micronits[1] could be addressed by a follow-up patch (if
> desirable), but probably needn't hold up this patch.
>
> [1]: https://public-inbox.org/git/871si0mvo0.fsf@evledraar.gmail.com/
Nicely done. Thanks, all.
Will queue.
prev parent reply other threads:[~2018-02-05 18:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-22 23:23 [PATCH] daemon: add --no-syslog to undo implicit --syslog Lucas Werkmeister
2018-01-23 0:00 ` Ævar Arnfjörð Bjarmason
2018-01-23 18:30 ` Junio C Hamano
2018-01-23 22:06 ` Lucas Werkmeister
2018-01-24 10:05 ` Lucas Werkmeister
2018-01-24 18:33 ` Junio C Hamano
2018-01-24 19:48 ` Lucas Werkmeister
2018-01-27 18:31 ` [PATCH v2] daemon: add --send-log-to=(stderr|syslog|none) Lucas Werkmeister
2018-01-28 6:40 ` Eric Sunshine
2018-01-28 22:58 ` Lucas Werkmeister
2018-01-29 0:10 ` Eric Sunshine
2018-02-03 23:08 ` [PATCH v3] daemon: add --log-destination=(stderr|syslog|none) Lucas Werkmeister
2018-02-04 6:36 ` Eric Sunshine
2018-02-04 18:29 ` Lucas Werkmeister
2018-02-04 18:30 ` [PATCH v4] " Lucas Werkmeister
2018-02-04 18:55 ` Ævar Arnfjörð Bjarmason
2018-02-04 18:58 ` Lucas Werkmeister
2018-02-05 20:09 ` Ævar Arnfjörð Bjarmason
2018-02-04 19:44 ` Eric Sunshine
2018-02-04 19:36 ` Eric Sunshine
2018-02-05 18:31 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqlgg7b855.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=mail@lucaswerkmeister.de \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).