From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Lucas Werkmeister <mail@lucaswerkmeister.de>
Cc: Eric Sunshine <sunshine@sunshineco.com>,
Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org
Subject: Re: [PATCH v4] daemon: add --log-destination=(stderr|syslog|none)
Date: Sun, 04 Feb 2018 19:55:43 +0100 [thread overview]
Message-ID: <871si0mvo0.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <20180204183037.23162-1-mail@lucaswerkmeister.de>
On Sun, Feb 04 2018, Lucas Werkmeister jotted:
> [--inetd |
> [--listen=<host_or_ipaddr>] [--port=<n>]
> [--user=<user> [--group=<group>]]]
> + [--log-destination=(stderr|syslog|none)]
I micronit, but maybe worthwhile to have a preceeding commit to fix up
that indentation of --listen and --user.
> +--log-destination=<destination>::
> + Send log messages to the specified destination.
> + Note that this option does not imply --verbose,
Should `` quote --verbose, although I see similar to the WS change I
noted above there's plenty of existing stuff in that doc doing it wrong.
> + } else
> + die("unknown log destination '%s'", v);
Should be die(_("unknown..., i.e. use the _() macro.
Anyway, this looks fine to be with our without these proposed
bikeshedding changes above. Thanks.
next prev parent reply other threads:[~2018-02-04 18:55 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-22 23:23 [PATCH] daemon: add --no-syslog to undo implicit --syslog Lucas Werkmeister
2018-01-23 0:00 ` Ævar Arnfjörð Bjarmason
2018-01-23 18:30 ` Junio C Hamano
2018-01-23 22:06 ` Lucas Werkmeister
2018-01-24 10:05 ` Lucas Werkmeister
2018-01-24 18:33 ` Junio C Hamano
2018-01-24 19:48 ` Lucas Werkmeister
2018-01-27 18:31 ` [PATCH v2] daemon: add --send-log-to=(stderr|syslog|none) Lucas Werkmeister
2018-01-28 6:40 ` Eric Sunshine
2018-01-28 22:58 ` Lucas Werkmeister
2018-01-29 0:10 ` Eric Sunshine
2018-02-03 23:08 ` [PATCH v3] daemon: add --log-destination=(stderr|syslog|none) Lucas Werkmeister
2018-02-04 6:36 ` Eric Sunshine
2018-02-04 18:29 ` Lucas Werkmeister
2018-02-04 18:30 ` [PATCH v4] " Lucas Werkmeister
2018-02-04 18:55 ` Ævar Arnfjörð Bjarmason [this message]
2018-02-04 18:58 ` Lucas Werkmeister
2018-02-05 20:09 ` Ævar Arnfjörð Bjarmason
2018-02-04 19:44 ` Eric Sunshine
2018-02-04 19:36 ` Eric Sunshine
2018-02-05 18:31 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871si0mvo0.fsf@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mail@lucaswerkmeister.de \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).