mailing list mirror (one of many)
 help / Atom feed
From: Junio C Hamano <>
To: "brian m. carlson" <>
Cc:, Nguyễn Thái Ngọc Duy <>,
	Patryk Obara <>, Jeff King <>,
	Eric Sunshine <>
Subject: Re: [PATCH v3 00/36] object_id part 12
Date: Wed, 14 Mar 2018 10:31:37 -0700
Message-ID: <> (raw)
In-Reply-To: <>

"brian m. carlson" <> writes:

>     -+		buf += the_hash_algo->rawsz;
>     -+		size -= the_hash_algo->rawsz;
>     ++		memcpy(it->oid.hash, (const unsigned char*)buf, rawsz);
>     ++		buf += rawsz;
>     ++		size -= rawsz;
>       	}

Using memcpy() to stuff the hash[] field of oid structure with a
bare byte array of rawsz bytes appears twice as a pattern in these
patches.  I wonder if this is something we want to abstract behind
the API, e.g.

	size_t oidstuff_(struct object_id *oid, const unsigned char *buf)
		size_t rawsz = the_hash_algo->rawsz;
		memcpy(oid->hash, buf, rawsz);
                return rawsz;

It just felt a bit uneven to be using a bare-metal memcpy() when
oidcpy() abstraction releaves the callers from having to be aware of
the rawsz all the time.

  parent reply index

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-12  2:27 brian m. carlson
2018-03-12  2:27 ` [PATCH v3 02/36] builtin/write-tree: convert to struct object_id brian m. carlson
2018-03-14 16:48 ` [PATCH v3 00/36] object_id part 12 Junio C Hamano
2018-03-14 19:46   ` Junio C Hamano
2018-03-15  1:05   ` brian m. carlson
2018-03-14 17:31 ` Junio C Hamano [this message]
2018-03-15  0:53   ` brian m. carlson

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link mailing list mirror (one of many)

Archives are clonable:
	git clone --mirror
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

Newsgroups are available over NNTP:

 note: .onion URLs require Tor:
       or Tor2web:

AGPL code for this site: git clone public-inbox