mailing list mirror (one of many)
 help / Atom feed
From: "brian m. carlson" <>
To: Junio C Hamano <>
Cc:, Nguyễn Thái Ngọc Duy <>,
	Patryk Obara <>, Jeff King <>,
	Eric Sunshine <>
Subject: Re: [PATCH v3 00/36] object_id part 12
Date: Thu, 15 Mar 2018 01:05:39 +0000
Message-ID: <> (raw)
In-Reply-To: <>

[-- Attachment #1: Type: text/plain, Size: 1165 bytes --]

On Wed, Mar 14, 2018 at 09:48:30AM -0700, Junio C Hamano wrote:
> As always, thanks for working on this.  
> After this series, what jumps at me out of output from
>     git grep -e '[^0-9A-Za-z_][24]0[^0-9A-Za-z_]' -- '*.[ch]' \
> 		':!*sha1*' ':!contrib/' ':!compat/'
> are code that parses the incoming patch in apply.c (where the full
> blob object names used for binary patches are assumed to be in
> SHA-1), builtin/pack-objects.c (where it has to know the current
> file format of a packfile intimately) and diff.c (where it clips the
> length to which the blob object names on the "index" lines are
> abbreviated to).  Changing 40 in the last one to "the hex length of
> the currently deployed hash" should be relatively uncontroversial.

I have patches that hit several of these places, but not diff.c.  I'll
probably pick that piece up next.

By the way, thanks for a useful regex.  It's a little bit different
than what I've been using, but provides a nice overview.
brian m. carlson / brian with sandals: Houston, Texas, US | My opinion only

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 867 bytes --]

  parent reply index

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-12  2:27 brian m. carlson
2018-03-12  2:27 ` [PATCH v3 02/36] builtin/write-tree: convert to struct object_id brian m. carlson
2018-03-14 16:48 ` [PATCH v3 00/36] object_id part 12 Junio C Hamano
2018-03-14 19:46   ` Junio C Hamano
2018-03-15  1:05   ` brian m. carlson [this message]
2018-03-14 17:31 ` Junio C Hamano
2018-03-15  0:53   ` brian m. carlson

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link mailing list mirror (one of many)

Archives are clonable:
	git clone --mirror
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

Newsgroups are available over NNTP:

 note: .onion URLs require Tor:
       or Tor2web:

AGPL code for this site: git clone public-inbox