From: Junio C Hamano <gitster@pobox.com>
To: Eric Freese <ericdfreese@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [RFC PATCH 1/1] for-each-ref: do not output empty lines
Date: Mon, 09 Sep 2019 23:14:33 -0700 [thread overview]
Message-ID: <xmqqlfuwhe46.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <xmqqpnk8heow.fsf@gitster-ct.c.googlers.com> (Junio C. Hamano's message of "Mon, 09 Sep 2019 23:02:07 -0700")
Junio C Hamano <gitster@pobox.com> writes:
>> fwrite(final_buf.buf, 1, final_buf.len, stdout);
>> + if (final_buf.len)
>> + putchar('\n');
>
> While we are introducing a conditional, let's drop the useless
> fwrite of 0-byte while we are at it [*1*], i.e.
>
> if (final_buf.len && !omit_empty_lines) {
Of course, that's a typo for "||"; if it is not empty, we'd emit no
matter what, and if omit_empty is not given, we'd emit whether it is
empty or not.
> fwrite(final_buf.buf, 1, final_buf.len, stdout);
> putchar('\n');
> }
>
> Thanks.
>
>
> [Footnote]
>
> *1* "While we are at it", the existing code tempts me to drop fwrite
> and replace it with something along the lines of...
>
> printf("%*s\n", count, buf)
>
> but I refrained from doing so. An enhancement patch like this
> is not a place to "improve" existing code (which should be done
> as a separate patch).
next prev parent reply other threads:[~2019-09-10 6:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-10 5:17 [RFC PATCH 0/1] for-each-ref: do not output empty lines Eric Freese
2019-09-10 5:17 ` [RFC PATCH 1/1] " Eric Freese
2019-09-10 6:02 ` Junio C Hamano
2019-09-10 6:14 ` Junio C Hamano [this message]
2019-09-10 16:35 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqlfuwhe46.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=ericdfreese@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).