From: Junio C Hamano <gitster@pobox.com>
To: Eric Freese <ericdfreese@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [RFC PATCH 1/1] for-each-ref: do not output empty lines
Date: Mon, 09 Sep 2019 23:02:07 -0700 [thread overview]
Message-ID: <xmqqpnk8heow.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20190910051705.2765-2-ericdfreese@gmail.com> (Eric Freese's message of "Mon, 9 Sep 2019 23:17:05 -0600")
Eric Freese <ericdfreese@gmail.com> writes:
> If the format string expands to an empty string for a given ref, do not
> print the empty line.
>
> This is helpful when wanting to print only certain kinds of refs that
> you can't already filter for.
We tend to prefer stating the reason why we want to do so first and
then give a command to the codebase to "become like so". Here is to
illustrate how you would do it:
The custom format specifier "--format=<format>" can be used to
tell the for-each-ref command to say nothing for certain kind of
refs, e.g.
--format="%(if)%(symref)%(then)%(else)%(refname)%(end)"
may be used to show the refname only for refs that are not
symbolic refs. Except that the command still would show one
blank line per each symbolic ref, which is fairly useless.
Introduce the `--omit-empty-lines` option to squelch these
useless lines from the output.
> @@ -2395,9 +2395,10 @@ void show_ref_array_item(struct ref_array_item *info,
> if (format_ref_array_item(info, format, &final_buf, &error_buf))
> die("%s", error_buf.buf);
> fwrite(final_buf.buf, 1, final_buf.len, stdout);
> + if (final_buf.len)
> + putchar('\n');
While we are introducing a conditional, let's drop the useless
fwrite of 0-byte while we are at it [*1*], i.e.
if (final_buf.len && !omit_empty_lines) {
fwrite(final_buf.buf, 1, final_buf.len, stdout);
putchar('\n');
}
Thanks.
[Footnote]
*1* "While we are at it", the existing code tempts me to drop fwrite
and replace it with something along the lines of...
printf("%*s\n", count, buf)
but I refrained from doing so. An enhancement patch like this
is not a place to "improve" existing code (which should be done
as a separate patch).
next prev parent reply other threads:[~2019-09-10 6:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-10 5:17 [RFC PATCH 0/1] for-each-ref: do not output empty lines Eric Freese
2019-09-10 5:17 ` [RFC PATCH 1/1] " Eric Freese
2019-09-10 6:02 ` Junio C Hamano [this message]
2019-09-10 6:14 ` Junio C Hamano
2019-09-10 16:35 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpnk8heow.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=ericdfreese@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).