From: Junio C Hamano <gitster@pobox.com>
To: Olliver Schinagl <oliver@schinagl.nl>
Cc: phillip.wood123@gmail.com, phillip.wood@dunelm.org.uk,
git@vger.kernel.org,
Christian Couder <christian.couder@gmail.com>,
Stefan Haller <lists@haller-berlin.de>
Subject: Re: [RFC] bisect: Introduce skip-when to automatically skip commits
Date: Wed, 10 Apr 2024 12:31:37 -0700 [thread overview]
Message-ID: <xmqqle5lrp46.fsf@gitster.g> (raw)
In-Reply-To: <bb0dc4a7-e598-45f5-b707-e22de0890f26@schinagl.nl> (Olliver Schinagl's message of "Wed, 10 Apr 2024 21:22:31 +0200")
Olliver Schinagl <oliver@schinagl.nl> writes:
> See, the hook is named 'post-checkout' and thus, it runs after
> checkout has been performed. So we are now on the 'broken' commit we
> do not want to test, git should have skipped this already, and not
> checked it out.
You are not the only user of this feature (by the way, do not call
this a "hook". It should be per "git bisect" session) and others
may need to actually inspect their working tree state before being
able to say "nah, I do not want to test this version, please give me
another one" by exiting with 125. That is why post-checkout is more
useful in general. Contrasted with that, a check that happens
before the checkout is useful only in a much narrower "I can tell by
looking only at the commit object name" use case, which I would not
be interested in seeing.
Thanks.
next prev parent reply other threads:[~2024-04-10 19:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-30 8:10 [RFC] bisect: Introduce skip-when to automatically skip commits Olliver Schinagl
2024-04-05 6:50 ` Olliver Schinagl
2024-04-06 1:08 ` Junio C Hamano
2024-04-06 10:06 ` Olliver Schinagl
2024-04-06 13:50 ` Phillip Wood
2024-04-06 19:17 ` Olliver Schinagl
2024-04-07 14:09 ` phillip.wood123
2024-04-07 14:52 ` Olliver Schinagl
2024-04-07 15:12 ` phillip.wood123
2024-04-07 21:11 ` Olliver Schinagl
2024-04-08 16:49 ` Junio C Hamano
2024-04-10 10:39 ` Olliver Schinagl
2024-04-10 16:47 ` Junio C Hamano
2024-04-10 19:22 ` Olliver Schinagl
2024-04-10 19:31 ` Junio C Hamano [this message]
2024-04-10 19:39 ` Olliver Schinagl
2024-04-12 13:35 ` Phillip Wood
2024-04-06 17:07 ` Junio C Hamano
2024-04-06 19:19 ` Olliver Schinagl
2024-04-06 10:22 ` Olliver Schinagl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqle5lrp46.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=lists@haller-berlin.de \
--cc=oliver@schinagl.nl \
--cc=phillip.wood123@gmail.com \
--cc=phillip.wood@dunelm.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).