From: Olliver Schinagl <oliver@schinagl.nl>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org,
Christian Couder <christian.couder@gmail.com>,
Stefan Haller <lists@haller-berlin.de>
Subject: Re: [RFC] bisect: Introduce skip-when to automatically skip commits
Date: Sat, 6 Apr 2024 12:22:44 +0200 [thread overview]
Message-ID: <30eccdbc-f0c4-4b8f-b735-cf5613912a9f@schinagl.nl> (raw)
In-Reply-To: <xmqqcyr3s3gj.fsf@gitster.g>
On 06-04-2024 03:08, Junio C Hamano wrote:
> Olliver Schinagl <oliver@schinagl.nl> writes:
>
>> Hey all,
>>
>> I've also got my work on a branch in my repo, if that helps to look at
>> things, https://gitlab.com/olliver/git/-/tree/skip_bisect
>>
>> Also included is a script to be used as an example. I opted to use
>> `git show`, which is nice because it works both on commits, but also
>> on notes.
>>
>> Anyway, any thoughts on the bellow before I send the full series?
>>
>> Olliver
>
> I would not write get_skip_when() before studying the same file to
> see if there already is a helper to read the whole file used in the
> vicinity (like strbuf_read_file(), perhaps).
So I just remembered, when I started this journey, I wanted to squeeze
it all into `get_terms()` and make it part of the terms struct, as that
was passed around everywhere. I figured, I can rename it into being
something more generic. But I realized that skip_when doesn't actually
need to be passed around at all (which we can see in the current
implementation). With get_terms() in my mind, I just what that function did.
I saw strbuf_read_file() but I didn't quite understand what it was
doing, it was a bit cryptic at first. Now that you mention it however, I
see the error of my ways, and that strbuf_read_file() might be good
enough and do exactly what get_skip_when does.
So thank you for that hint :)
Olliver
>
> I do not have enough concentration to follow changes to
> bisect_auto_next() is reasonable. Especially I do not know why
> "bisect-skip_when" wants to exist and what it is trying to do,
> besides the fact that its name looks horrible ;-).
>
prev parent reply other threads:[~2024-04-06 10:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-30 8:10 [RFC] bisect: Introduce skip-when to automatically skip commits Olliver Schinagl
2024-04-05 6:50 ` Olliver Schinagl
2024-04-06 1:08 ` Junio C Hamano
2024-04-06 10:06 ` Olliver Schinagl
2024-04-06 13:50 ` Phillip Wood
2024-04-06 19:17 ` Olliver Schinagl
2024-04-07 14:09 ` phillip.wood123
2024-04-07 14:52 ` Olliver Schinagl
2024-04-07 15:12 ` phillip.wood123
2024-04-07 21:11 ` Olliver Schinagl
2024-04-08 16:49 ` Junio C Hamano
2024-04-10 10:39 ` Olliver Schinagl
2024-04-10 16:47 ` Junio C Hamano
2024-04-10 19:22 ` Olliver Schinagl
2024-04-10 19:31 ` Junio C Hamano
2024-04-10 19:39 ` Olliver Schinagl
2024-04-12 13:35 ` Phillip Wood
2024-04-06 17:07 ` Junio C Hamano
2024-04-06 19:19 ` Olliver Schinagl
2024-04-06 10:22 ` Olliver Schinagl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30eccdbc-f0c4-4b8f-b735-cf5613912a9f@schinagl.nl \
--to=oliver@schinagl.nl \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=lists@haller-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).