From: Junio C Hamano <gitster@pobox.com>
To: Vasco Almeida <vascomalmeida@sapo.pt>
Cc: git@vger.kernel.org, Jiang Xin <worldhello.net@gmail.com>
Subject: Re: [PATCH v2 3/7] i18n: git-parse-remote.sh: mark strings for translation
Date: Tue, 12 Apr 2016 10:47:20 -0700 [thread overview]
Message-ID: <xmqqk2k2ra6v.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <1460234324-13506-3-git-send-email-vascomalmeida@sapo.pt> (Vasco Almeida's message of "Sat, 9 Apr 2016 20:38:40 +0000")
Vasco Almeida <vascomalmeida@sapo.pt> writes:
> diff --git a/git-parse-remote.sh b/git-parse-remote.sh
> index 55fe8d5..c5e5840 100644
> --- a/git-parse-remote.sh
> +++ b/git-parse-remote.sh
> @@ -6,6 +6,9 @@
> # this would fail in that case and would issue an error message.
> GIT_DIR=$(git rev-parse -q --git-dir) || :;
>
> +. git-sh-setup
> +. git-sh-i18n
This hunk should be dropped, I think.
The scriptlet is not meant to be used as a standalone command and is
designed to be always used with ". git-parse-remote". The scripted
command that uses it would already have done the above two.
> @@ -68,22 +73,33 @@ error_on_missing_default_upstream () {
>
> if test -z "$branch_name"
> then
> - echo "You are not currently on a branch. Please specify which
> -branch you want to $op_type $op_prep. See git-${cmd}(1) for details.
> -
> - $example
> -"
> + gettextln "You are not currently on a branch."
> + if test "$op_type" = rebase
> + then
> + gettextln "Please specify which branch you want to rebase against."
> + else
> + gettextln "Please specify which branch you want to merge with."
> + fi
The original did not have to know $op_type can only be rebase or
merge, but this one hardcodes the assumption. To make sure that
anybody who adds yet another way to rebase need to come up with a
phrasing that is suited for the new way, something like this would
be a good way to future-proof it.
case "$op_type" in
rebase)
... ;;
merge)
... ;;
*)
echo >&2 "BUG: ..."
exit 1 ;;
esac
next prev parent reply other threads:[~2016-04-12 17:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-09 20:38 [PATCH v2 1/7] i18n: index-pack: use plural string instead of normal one Vasco Almeida
2016-04-09 20:38 ` [PATCH v2 2/7] i18n: unpack-trees: mark strings for translation Vasco Almeida
2016-04-09 20:38 ` [PATCH v2 3/7] i18n: git-parse-remote.sh: " Vasco Almeida
2016-04-12 17:47 ` Junio C Hamano [this message]
2016-04-09 20:38 ` [PATCH v2 4/7] i18n: builtin/pull.c: " Vasco Almeida
2016-04-10 18:01 ` Junio C Hamano
2016-04-11 10:43 ` Vasco Almeida
2016-04-12 9:52 ` Duy Nguyen
2016-04-29 6:57 ` Jean-Noël Avila
2016-04-09 20:38 ` [PATCH v2 5/7] i18n: builtin/pull.c: split strings marked " Vasco Almeida
2016-04-09 20:38 ` [PATCH v2 6/7] i18n: builtin/rm.c: remove a comma ',' from string Vasco Almeida
2016-04-09 20:38 ` [PATCH v2 7/7] i18n: builtin/branch.c: mark option for translation Vasco Almeida
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk2k2ra6v.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=vascomalmeida@sapo.pt \
--cc=worldhello.net@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).