From: Junio C Hamano <gitster@pobox.com>
To: Mike Hommey <mh@glandium.org>
Cc: Eric Sunshine <sunshine@sunshineco.com>, Git List <git@vger.kernel.org>
Subject: Re: SHA1dc on mac
Date: Wed, 12 Feb 2020 14:40:37 -0800 [thread overview]
Message-ID: <xmqqk14rtonu.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20200212223122.svthiwmh3js7i47b@glandium.org> (Mike Hommey's message of "Thu, 13 Feb 2020 07:31:22 +0900")
Mike Hommey <mh@glandium.org> writes:
> On Wed, Feb 12, 2020 at 11:46:31AM -0500, Eric Sunshine wrote:
>> On Wed, Feb 12, 2020 at 3:57 AM Mike Hommey <mh@glandium.org> wrote:
>> > If I'm not mistaken in my reading of the various files involved, it
>> > looks like for some reason, building git on mac leads to using Apple
>> > Common Crypto for SHA1, rather than SHA1dc, which seems unfortunate.
>> > Is that really expected?
>>
>> There was a discussion on this topic a while back[1], and it does seem
>> that the behavior you describe is intentional[2].
>
> That discussion predates SHA1dc, though.
Yes, but the essense is the same. It was phrased as "is there a
good reason to prefer CommonCrypto over block-sha1?" but it really
was "is there a good reason to prefer CommonCrypto over the best we
offer?" And the best we offer, which used to be block-sha1, is now
sha1dc.
next prev parent reply other threads:[~2020-02-12 22:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 8:56 SHA1dc on mac Mike Hommey
2020-02-12 16:46 ` Eric Sunshine
2020-02-12 22:31 ` Mike Hommey
2020-02-12 22:40 ` Junio C Hamano [this message]
2020-02-23 22:37 ` [PATCH] Remove non-SHA1dc sha1 implementations Mike Hommey
2020-02-24 4:47 ` Jeff King
2020-02-24 4:52 ` Jeff King
2022-03-19 1:02 ` [PATCH] ppc: remove custom SHA-1 implementation Ævar Arnfjörð Bjarmason
2022-03-21 16:39 ` Junio C Hamano
2022-03-21 17:06 ` [PATCH v2] " Ævar Arnfjörð Bjarmason
2022-03-21 21:19 ` brian m. carlson
2022-08-31 9:18 ` [PATCH v3 0/2] Makefile + hash.h: remove PPC_SHA1 implementation Ævar Arnfjörð Bjarmason
2022-08-31 9:18 ` [PATCH v3 1/2] " Ævar Arnfjörð Bjarmason
2022-08-31 9:18 ` [PATCH v3 2/2] Makefile: use $(OBJECTS) instead of $(C_OBJ) Ævar Arnfjörð Bjarmason
2022-08-31 21:44 ` Junio C Hamano
2022-09-01 14:52 ` Ævar Arnfjörð Bjarmason
2022-09-01 15:48 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk14rtonu.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=mh@glandium.org \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).