From: Jeff King <peff@peff.net>
To: Mike Hommey <mh@glandium.org>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] Remove non-SHA1dc sha1 implementations
Date: Sun, 23 Feb 2020 23:52:13 -0500 [thread overview]
Message-ID: <20200224045213.GA1574706@coredump.intra.peff.net> (raw)
In-Reply-To: <20200224044732.GK1018190@coredump.intra.peff.net>
On Sun, Feb 23, 2020 at 11:47:32PM -0500, Jeff King wrote:
> One thing that compels me is the recent report that we still build with
> common crypto by default on macOS, which was definitely _not_ intended.
> That's a bug that can be fixed, but it wouldn't have happened in the
> first place if we only supported sha1dc.
I just noticed you were the original reporter there, too. So I guess it
compelled you, too. ;)
If we do want to keep the other implementations around, another thing
that might be worth doing is to teach t0013 to complain when the
collision-detecting sha1 is not in use (i.e., rather than auto-skipping
when built without DC_SHA1, require the user to set a special
NO_REALLY_I_CHOOSE_NOT_TO_USE_DC_SHA1_AND_AM_AWARE_OF_THE_IMPLICATIONS
variable). That would provide a cross-check on the build flags.
-Peff
next prev parent reply other threads:[~2020-02-24 4:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 8:56 SHA1dc on mac Mike Hommey
2020-02-12 16:46 ` Eric Sunshine
2020-02-12 22:31 ` Mike Hommey
2020-02-12 22:40 ` Junio C Hamano
2020-02-23 22:37 ` [PATCH] Remove non-SHA1dc sha1 implementations Mike Hommey
2020-02-24 4:47 ` Jeff King
2020-02-24 4:52 ` Jeff King [this message]
2022-03-19 1:02 ` [PATCH] ppc: remove custom SHA-1 implementation Ævar Arnfjörð Bjarmason
2022-03-21 16:39 ` Junio C Hamano
2022-03-21 17:06 ` [PATCH v2] " Ævar Arnfjörð Bjarmason
2022-03-21 21:19 ` brian m. carlson
2022-08-31 9:18 ` [PATCH v3 0/2] Makefile + hash.h: remove PPC_SHA1 implementation Ævar Arnfjörð Bjarmason
2022-08-31 9:18 ` [PATCH v3 1/2] " Ævar Arnfjörð Bjarmason
2022-08-31 9:18 ` [PATCH v3 2/2] Makefile: use $(OBJECTS) instead of $(C_OBJ) Ævar Arnfjörð Bjarmason
2022-08-31 21:44 ` Junio C Hamano
2022-09-01 14:52 ` Ævar Arnfjörð Bjarmason
2022-09-01 15:48 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200224045213.GA1574706@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mh@glandium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).