From: Junio C Hamano <gitster@pobox.com>
To: Chen BoJun <bojun.cbj@gmail.com>
Cc: git@vger.kernel.org, "Chen Bojun" <bojun.cbj@alibaba-inc.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Jiang Xin" <zhiyou.jx@alibaba-inc.com>,
"Teng Long" <dyroneteng@gmail.com>
Subject: Re: [PATCH v2] receive-pack: purge temporary data if no command is ready to run
Date: Tue, 01 Feb 2022 15:27:25 -0800 [thread overview]
Message-ID: <xmqqk0ee9nhe.fsf@gitster.g> (raw)
In-Reply-To: <xmqqczk6b3pt.fsf@gitster.g> (Junio C. Hamano's message of "Tue, 01 Feb 2022 14:51:26 -0800")
Junio C Hamano <gitster@pobox.com> writes:
>> index 9f4a0b816c..a0b193ab3f 100644
>> --- a/builtin/receive-pack.c
>> +++ b/builtin/receive-pack.c
>> @@ -1971,6 +1971,15 @@ static void execute_commands(struct command *commands,
>> return;
>> }
>
> With the new logic, "return;" we see above becomes unnecessary. I
> wonder if it is a good idea to keep it or remove it.
I think it makes the code easier to maintain to keep the above
"return;". There may be some code added in the future right here,
before the final "if no ref updates succeeds, leave early" this
patch adds, and it is unlikely we would want to run it when
pre-receive rejects the push.
IOW, this part of the patch that did not touch the above "return;"
is just fine as-is.
Thanks.
next prev parent reply other threads:[~2022-02-01 23:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-24 1:26 [PATCH] receive-pack: purge temporary data if no command is ready to run BoJun via GitGitGadget
2022-01-24 15:17 ` Ævar Arnfjörð Bjarmason
2022-01-25 16:34 ` Lertz Chen
2022-01-24 23:32 ` Junio C Hamano
2022-01-25 16:49 ` Bojun Chen
2022-01-25 0:22 ` Jiang Xin
2022-01-29 6:35 ` [PATCH v2] " Chen BoJun
2022-02-01 22:51 ` Junio C Hamano
2022-02-01 23:27 ` Junio C Hamano [this message]
2022-02-05 7:17 ` Bojun Chen
2022-02-05 8:04 ` Junio C Hamano
2022-02-07 3:36 ` Jiang Xin
2022-02-07 8:02 ` Bojun Chen
2022-02-04 1:17 ` Junio C Hamano
2022-02-05 7:19 ` Bojun Chen
2022-02-05 8:02 ` Junio C Hamano
2022-02-07 7:57 ` [PATCH v3 0/1] " Chen BoJun
2022-02-07 7:57 ` [PATCH v3 1/1] receive-pack: " Chen BoJun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk0ee9nhe.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=bojun.cbj@alibaba-inc.com \
--cc=bojun.cbj@gmail.com \
--cc=dyroneteng@gmail.com \
--cc=git@vger.kernel.org \
--cc=zhiyou.jx@alibaba-inc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).