From: Bojun Chen <bojun.cbj@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: BoJun via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Chen Bojun <bojun.cbj@alibaba-inc.com>
Subject: Re: [PATCH] receive-pack: purge temporary data if no command is ready to run
Date: Wed, 26 Jan 2022 00:49:52 +0800 [thread overview]
Message-ID: <CADuS7Aov-J4LjAm_e_DOHaAba9JHFFV-2trxBywzL4vtwuvr4Q@mail.gmail.com> (raw)
In-Reply-To: <xmqqk0eo1zhu.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> 于2022年1月25日周二 07:32写道:
>
> > + /*
> > + * If there is no command ready to run, should return directly to destroy
> > + * temporary data in the quarantine area.
> > + */
> > + for (cmd = commands; cmd && cmd->error_string; cmd = cmd->next);
>
> Write the empty body of the loop like this:
>
> for (...)
> ; /* nothing */
>
> to make it stand out.
>
Thanks for the suggestion, this is more readable.
> > + if (!cmd)
> > + return;
> > +
>
> > -mk_empty () {
> > +mk_empty() {
> > repo_name="$1"
> > rm -fr "$repo_name" &&
> > - mkdir "$repo_name" &&
> > - (
> > - cd "$repo_name" &&
> > - git init &&
> > - git config receive.denyCurrentBranch warn &&
> > - mv .git/hooks .git/hooks-disabled
> > - )
> > + mkdir "$repo_name" &&
> > + (
> > + cd "$repo_name" &&
> > + git init &&
> > + git config receive.denyCurrentBranch warn &&
> > + mv .git/hooks .git/hooks-disabled
> > + )
> > }
>
> Documentation/CodingGuidelines. As far as I can tell, the above
> does not change anything the function does, and the only change in
> the patch is to violate the style guide badly. Why?
Sorry. I'll roll back these formatting issues. Jiang Xin reminded me to
look at this document, but I did miss an important part. At the same
time, I used a wrong range-diff command in the review I sent internally
earlier, which made my changes look like "mk_empty() {"
to "mk_empty () {". So this problem was not detected in time.
next prev parent reply other threads:[~2022-01-25 16:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-24 1:26 [PATCH] receive-pack: purge temporary data if no command is ready to run BoJun via GitGitGadget
2022-01-24 15:17 ` Ævar Arnfjörð Bjarmason
2022-01-25 16:34 ` Lertz Chen
2022-01-24 23:32 ` Junio C Hamano
2022-01-25 16:49 ` Bojun Chen [this message]
2022-01-25 0:22 ` Jiang Xin
2022-01-29 6:35 ` [PATCH v2] " Chen BoJun
2022-02-01 22:51 ` Junio C Hamano
2022-02-01 23:27 ` Junio C Hamano
2022-02-05 7:17 ` Bojun Chen
2022-02-05 8:04 ` Junio C Hamano
2022-02-07 3:36 ` Jiang Xin
2022-02-07 8:02 ` Bojun Chen
2022-02-04 1:17 ` Junio C Hamano
2022-02-05 7:19 ` Bojun Chen
2022-02-05 8:02 ` Junio C Hamano
2022-02-07 7:57 ` [PATCH v3 0/1] " Chen BoJun
2022-02-07 7:57 ` [PATCH v3 1/1] receive-pack: " Chen BoJun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADuS7Aov-J4LjAm_e_DOHaAba9JHFFV-2trxBywzL4vtwuvr4Q@mail.gmail.com \
--to=bojun.cbj@gmail.com \
--cc=bojun.cbj@alibaba-inc.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).