git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Stefan Beller <sbeller@google.com>, git@vger.kernel.org
Subject: Re: [PATCH 5/6] bundle: don't leak an fd in case of early return
Date: Wed, 30 Mar 2016 10:19:09 -0700	[thread overview]
Message-ID: <xmqqio03ubn6.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20160330011743.GD2237@sigill.intra.peff.net> (Jeff King's message of "Tue, 29 Mar 2016 21:17:43 -0400")

Jeff King <peff@peff.net> writes:

>> +	if (compute_and_write_prerequisites(bundle_fd, &revs, argc, argv)) {
>> +		if (!bundle_to_stdout)
>> +			close(bundle_fd);
>>  		return -1;
>> +	}
>
> Makes sense. Should we also be rolling back the lock file? It happens
> automatically at program exit, of course, but we are in library code
> here that should not rely on that.

Yeah, I agree.  I suspect that the original wasn't even meant to be
used in a "library-ish" fashion, but as long as we are adding this
close(), we should also be doing the rollback.

Thanks.

  reply	other threads:[~2016-03-30 17:19 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-30  0:38 [PATCH 0/6] Some cleanups Stefan Beller
2016-03-30  0:38 ` [PATCH 1/6] path.c: allocate enough memory for string Stefan Beller
2016-03-30  0:56   ` Junio C Hamano
2016-03-30  0:57   ` Eric Sunshine
2016-03-30 16:41     ` Stefan Beller
2016-03-30 17:16       ` Junio C Hamano
2016-03-30  0:38 ` [PATCH 2/6] imap-send.c, cram: allocate enough memory for null terminated string Stefan Beller
2016-03-30  1:02   ` Eric Sunshine
2016-03-30  1:07   ` Jeff King
2016-03-30  0:38 ` [PATCH 3/6] notes: don't leak memory in git_config_get_notes_strategy Stefan Beller
2016-03-30  1:11   ` Eric Sunshine
2016-03-30  1:13   ` Jeff King
2016-03-30 17:17     ` Junio C Hamano
2016-03-30  0:38 ` [PATCH 4/6] abbrev_sha1_in_line: don't leak memory Stefan Beller
2016-03-30  1:11   ` Jeff King
2016-03-30  1:30     ` Eric Sunshine
2016-03-30  1:31       ` Jeff King
2016-03-30 17:06         ` Junio C Hamano
2016-03-30 17:21           ` Jeff King
2016-03-30  0:38 ` [PATCH 5/6] bundle: don't leak an fd in case of early return Stefan Beller
2016-03-30  1:17   ` Jeff King
2016-03-30 17:19     ` Junio C Hamano [this message]
2016-03-30  0:38 ` [PATCH 6/6] credential-cache, send_request: close fd when done Stefan Beller
2016-03-30  1:20   ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqio03ubn6.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    --cc=sbeller@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).