From: Junio C Hamano <gitster@pobox.com>
To: Ivan Pozdeev <vano@mail.mipt.ru>
Cc: git@vger.kernel.org, peff@peff.net
Subject: Re: [PATCH] Fix confusing wording
Date: Wed, 27 Dec 2017 11:44:38 -0800 [thread overview]
Message-ID: <xmqqincslzvd.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <8da9d436-88b9-7959-dd9c-65bdd376bf54@mail.mipt.ru> (Ivan Pozdeev's message of "Mon, 25 Dec 2017 13:26:37 +0300")
Ivan Pozdeev <vano@mail.mipt.ru> writes:
> Not sure if I should add a CVE-2009-0037 reference as well.
Not in an end-user facing message like this one, I would say.
>
> ---
Sign off?
> http.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/http.c b/http.c
> index 215bebe..26b3386 100644
> --- a/http.c
> +++ b/http.c
> @@ -802,7 +802,7 @@ static CURL *get_curl_handle(void)
> get_curl_allowed_protocols(-1));
> #else
> warning("protocol restrictions not applied to curl redirects because\n"
> - "your curl version is too old (>= 7.19.4)");
> + "your libcurl version is too old (< 7.19.4)");
> #endif
Between 'curl' and 'libcurl', the latter certainly is more
technically correct. I have a feeling that it would be better to
spell out ">=" as "requires at least" than replacing it with equally
cryptic "<" (it is OK to spell it out as "your libcurl version is
older than minimum required 7.19.4", too).
Thanks.
next prev parent reply other threads:[~2017-12-27 19:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-25 10:26 [PATCH] Fix confusing wording Ivan Pozdeev
2017-12-27 19:44 ` Junio C Hamano [this message]
2018-01-07 16:36 ` Ivan Pozdeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqincslzvd.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=vano@mail.mipt.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).