From: Ivan Pozdeev <vano@mail.mipt.ru>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, peff@peff.net
Subject: Re: [PATCH] Fix confusing wording
Date: Sun, 7 Jan 2018 19:36:19 +0300 [thread overview]
Message-ID: <ea302300-6f42-e6f5-16e2-81329a532788@mail.mipt.ru> (raw)
In-Reply-To: <xmqqincslzvd.fsf@gitster.mtv.corp.google.com>
On 27.12.2017 22:44, Junio C Hamano wrote:
> Ivan Pozdeev <vano@mail.mipt.ru> writes:
>
>> Not sure if I should add a CVE-2009-0037 reference as well.
> Not in an end-user facing message like this one, I would say.
To me, as an end user, the current message had no meaning at all. It
even sounds like I'm better off for having an old version 'cuz git tried
to apply some limitation to the download, and couldn't.
If it had "see <CVE> for more details", I could quickly find out the
message's real meaning. Currently, I have to `git blame' the source to
do that -- certainly something that few users would resort to.
>> ---
> Sign off?
https://github.com/native-api/git/blob/master/Documentation/SubmittingPatches
wasn't clear that this is required (TortoiseGit doesn't add it by
default). Do I need to remake the patch or something?
>> http.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/http.c b/http.c
>> index 215bebe..26b3386 100644
>> --- a/http.c
>> +++ b/http.c
>> @@ -802,7 +802,7 @@ static CURL *get_curl_handle(void)
>> get_curl_allowed_protocols(-1));
>> #else
>> warning("protocol restrictions not applied to curl redirects because\n"
>> - "your curl version is too old (>= 7.19.4)");
>> + "your libcurl version is too old (< 7.19.4)");
>> #endif
> Between 'curl' and 'libcurl', the latter certainly is more
> technically correct. I have a feeling that it would be better to
> spell out ">=" as "requires at least" than replacing it with equally
> cryptic "<" (it is OK to spell it out as "your libcurl version is
> older than minimum required 7.19.4", too).
I don't see how "your version is too old (less that <version>)" is unclear.
Any wording with "required" would be incorrect because a newer version
isn't really "required", git can work with an older one, too.
> Thanks.
You're welcome :-)
--
Regards,
Ivan
prev parent reply other threads:[~2018-01-07 16:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-25 10:26 [PATCH] Fix confusing wording Ivan Pozdeev
2017-12-27 19:44 ` Junio C Hamano
2018-01-07 16:36 ` Ivan Pozdeev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea302300-6f42-e6f5-16e2-81329a532788@mail.mipt.ru \
--to=vano@mail.mipt.ru \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).