* [OUTREACHY] [PATCH v2] t0000: replace test -f with helper function
@ 2020-10-20 17:32 caleb.tillman
2020-10-20 19:25 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: caleb.tillman @ 2020-10-20 17:32 UTC (permalink / raw)
To: git; +Cc: Caleb Tillman
From: Caleb Tillman <caleb.tillman@gmail.com>
Signed-off-by: Caleb Tillman <caleb.tillman@gmail.com>
---
t/t0000-basic.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t0000-basic.sh b/t/t0000-basic.sh
index 923281af93..eb99892a87 100755
--- a/t/t0000-basic.sh
+++ b/t/t0000-basic.sh
@@ -1191,7 +1191,7 @@ test_expect_success 'writing this tree with --missing-ok' '
test_expect_success 'git read-tree followed by write-tree should be idempotent' '
rm -f .git/index &&
git read-tree $tree &&
- test -f .git/index &&
+ test_path_is_file .git/index &&
newtree=$(git write-tree) &&
test "$newtree" = "$tree"
'
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [OUTREACHY] [PATCH v2] t0000: replace test -f with helper function
2020-10-20 17:32 [OUTREACHY] [PATCH v2] t0000: replace test -f with helper function caleb.tillman
@ 2020-10-20 19:25 ` Junio C Hamano
0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2020-10-20 19:25 UTC (permalink / raw)
To: caleb.tillman; +Cc: git
caleb.tillman@gmail.com writes:
> From: Caleb Tillman <caleb.tillman@gmail.com>
>
> Signed-off-by: Caleb Tillman <caleb.tillman@gmail.com>
> ---
Thanks. Let's declare victory and move on. You've demonstrated
through the microproject that you can now comfortably be involved in
the review discussion.
I'll keep the copy I queued on the 20th, though, with this title
t0000: use test_path_is_file instead of "test -f"
which is only slightly longer but is much more descriptive than this
round.
Thanks.
> t/t0000-basic.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/t0000-basic.sh b/t/t0000-basic.sh
> index 923281af93..eb99892a87 100755
> --- a/t/t0000-basic.sh
> +++ b/t/t0000-basic.sh
> @@ -1191,7 +1191,7 @@ test_expect_success 'writing this tree with --missing-ok' '
> test_expect_success 'git read-tree followed by write-tree should be idempotent' '
> rm -f .git/index &&
> git read-tree $tree &&
> - test -f .git/index &&
> + test_path_is_file .git/index &&
> newtree=$(git write-tree) &&
> test "$newtree" = "$tree"
> '
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-20 19:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-20 17:32 [OUTREACHY] [PATCH v2] t0000: replace test -f with helper function caleb.tillman
2020-10-20 19:25 ` Junio C Hamano
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).