From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org,
"Carlo Marcelo Arenas Belón" <carenas@gmail.com>,
"Jeff King" <peff@peff.net>,
"Phillip Wood" <phillip.wood123@gmail.com>,
"Eric Wong" <e@80x24.org>, "René Scharfe" <l.s.r@web.de>
Subject: Re: cb/pedantic-build-for-developers, POSIX-but-not-C99 and -Wno-pedantic-ms-format
Date: Wed, 22 Sep 2021 09:13:19 -0700 [thread overview]
Message-ID: <xmqqilys8u74.fsf@gitster.g> (raw)
In-Reply-To: <87lf3q9u6b.fsf@evledraar.gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Tue, 21 Sep 2021 10:44:02 +0200")
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> I.e. complaining about "%m$" instead of "%" in printf formats, it's easy
> enough to fix in my case, it's just something I used to de-duplicate a
> rather complex format, this makes it C(89|99)-compliant:
>
> - strbuf_addf(&fmt, "%%s%%s%%s-%%0%1$lud.%%0%1$lud-%%s-%%s-%%s",
> - (unsigned long)tmp.len);
> + strbuf_addf(&fmt, "%%s%%s%%s-%%0%lud.%%0%lud-%%s-%%s-%%s",
> + (unsigned long)tmp.len, (unsigned long)tmp.len);
>
> But in general, do we view -pedantic as an implicit endorsement that we
> should be using less POSIX and more standard C than we otherwise would?
>
> I may be wrong, but I believe that construct is widely portable, we
> don't use it in the main source, but in the po/ files (so anything that
> uses git + gettext tests for this already):
Reordering (_("%s %s"), a, b) to ("%2$s %1$s", a, b) is essential to
make po/ work.
While I do not think of a reason why it should not work, I am not
sure duplicating (%1$s %1$s", a) falls into the same category.
Any solution that makes the per-cent ridden format string is better
;-)
next prev parent reply other threads:[~2021-09-22 16:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-21 0:02 What's cooking in git.git (Sep 2021, #06; Mon, 20) Junio C Hamano
2021-09-21 1:16 ` Junio C Hamano
2021-09-21 3:22 ` Taylor Blau
2021-09-21 8:44 ` cb/pedantic-build-for-developers, POSIX-but-not-C99 and -Wno-pedantic-ms-format Ævar Arnfjörð Bjarmason
2021-09-21 10:10 ` Carlo Arenas
2021-09-21 10:30 ` René Scharfe
2021-09-21 10:48 ` Carlo Arenas
2021-09-22 16:15 ` Junio C Hamano
2021-09-22 16:58 ` René Scharfe
2021-09-22 16:13 ` Junio C Hamano [this message]
2021-09-22 16:25 ` Randall S. Becker
2021-09-22 17:22 ` Randall S. Becker
2021-09-22 17:38 ` Randall S. Becker
2021-09-21 23:07 ` What's cooking in git.git (Sep 2021, #06; Mon, 20) Ævar Arnfjörð Bjarmason
2021-09-23 16:36 ` Junio C Hamano
2021-09-23 16:51 ` Ævar Arnfjörð Bjarmason
2021-09-23 17:41 ` Jeff King
2021-09-22 0:22 ` ns/batched-fsync (was Re: What's cooking in git.git (Sep 2021, #06; Mon, 20)) Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqilys8u74.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=carenas@gmail.com \
--cc=e@80x24.org \
--cc=git@vger.kernel.org \
--cc=l.s.r@web.de \
--cc=peff@peff.net \
--cc=phillip.wood123@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).