From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, "Emily Shaffer" <emilyshaffer@google.com>,
"SZEDER Gábor" <szeder.dev@gmail.com>,
"Taylor Blau" <me@ttaylorr.com>,
"Jonathan Nieder" <jrnieder@gmail.com>
Subject: Re: What's cooking in git.git (Sep 2021, #06; Mon, 20)
Date: Thu, 23 Sep 2021 18:51:12 +0200 [thread overview]
Message-ID: <87mto343ze.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <xmqqczoz2qr3.fsf@gitster.g>
On Thu, Sep 23 2021, Junio C Hamano wrote:
> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>
>>> * ab/sanitize-leak-ci (2021-09-20) 2 commits
>>> - tests: add a test mode for SANITIZE=leak, run it in CI
>>> - Makefile: add SANITIZE=leak flag to GIT-BUILD-OPTIONS
>>>
>>> CI learns to run the leak sanitizer builds.
>>>
>>> Will merge to 'next'?
>>
>> Yes please, as noted in
>> https://lore.kernel.org/git/87r1dh8r62.fsf@evledraar.gmail.com/ more
>> leak fixes are waiting on this.
>
> Isn't the direction of dependency the other way? Once fixes go in,
> checks will no longer complain, but until fixes are reviewed and
> applied, checking at CI will break the testing and this would need
> working around by marking various tests as "not ready to be tested".
The fixes are structured as fixing the code, and then for both
self-documentation & testing turning on:
TEST_PASSES_SANITIZE_LEAK=true
In the same commit, I could fix the leaks and have a second series later
for turning on the regression test, or just turning on the test and
having it kick in once it's merged with ab/sanitize-leak-ci, but waiting
until ab/sanitize-leak-ci hit master first seemed less confusing for
everyone.
But if you'd like to have 'em now with either of those caveats...
>> It seems due to the size of this series we might be better off splitting
>> up this already split-up series.
>>
>> I was trying to convince you to merge down the much more trivial changes
>> up to the <mark0> above, which are purely build system prep work. Any
>> chance you'd reconsider?
>>
>> I think a plan that might be better would be:
>>
>> 1. Eject both ab/config-based-hooks-base & es/config-based-hooks
>> 2. I'd submit a series up to the <mark0>, hopefully that can land fairly
>> soon thereafter.
>> 3. Once that's in, another one for <mark0>..<mark1>, i.e. the "git hook
>> run" command, but only the more basic bits, and migrating fairly
>> simple hooks.
>> 4. Then <mark1>..<mark2>, followed by <mark2>..ab/config-based-hooks-base
>> 5. Then Emily's es/config-based-hooks.
>>
>> That's converting a 2-step process (ab/config-based-hooks-base +
>> es/config-based-hooks) into 5 steps, but I suspect it would go faster,
>> right now it seems there's no takers for a review of this rather large
>> series. What do you & Emily think?
[Just for anyone reading along, I've since pulled the trigger on that
proposed plan at
https://lore.kernel.org/git/cover-0.8-00000000000-20210923T095326Z-avarab@gmail.com/]
> Today I learned a phrase "six of one and half a dozen of another" ;-)
>
> I have been wondering if something like a book reading club is
> doable on the list. A chairperson nominates (and perhaps resends) a
> series of patches that is of manageable size to be reviewed, perhaps
> even prime the discussion with some comments, likeminded folks chime
> in and we end up with a reviewed series?
Some of your colleagues at Google have been running such a review for
what I understand to have been a while, and have recently started
inviting external people. I attended one & applaud the effort.
I think we could run a similar thing here on-list if there's interest
(I'd participate). Perhaps just:
1. Include a list of un-loved topics in What's Cooking (or someone
could do it as a follow-up)
2. Pick N, and distill it down to one, either asa BDFL decision or via
some easy voting mechanism, like https://doodle.com or E-Mail replies.
3. Send out a call for reviews with a re-send some time (a week?) later.
If you're not up for organizing it with everything you've got on your
plate I'd be up for doing it. I'd basically just:
1. Read What's Cooking, subjectively note topics that seem to need love.
2. Pick one for next week's on-list review club. Via the BFDL-decreed
methof of "shuf | head -n 1" or similar.
3. Send out weekly REVIEW CLUB E-Mail with a link to the relevant
series (if active), or have it be a --cover-letter with a full
re-send if it's been dead on-list for long enough for nobody to be
bothered by two parallel threads as a result.
What do you & others think?
next prev parent reply other threads:[~2021-09-23 17:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-21 0:02 What's cooking in git.git (Sep 2021, #06; Mon, 20) Junio C Hamano
2021-09-21 1:16 ` Junio C Hamano
2021-09-21 3:22 ` Taylor Blau
2021-09-21 8:44 ` cb/pedantic-build-for-developers, POSIX-but-not-C99 and -Wno-pedantic-ms-format Ævar Arnfjörð Bjarmason
2021-09-21 10:10 ` Carlo Arenas
2021-09-21 10:30 ` René Scharfe
2021-09-21 10:48 ` Carlo Arenas
2021-09-22 16:15 ` Junio C Hamano
2021-09-22 16:58 ` René Scharfe
2021-09-22 16:13 ` Junio C Hamano
2021-09-22 16:25 ` Randall S. Becker
2021-09-22 17:22 ` Randall S. Becker
2021-09-22 17:38 ` Randall S. Becker
2021-09-21 23:07 ` What's cooking in git.git (Sep 2021, #06; Mon, 20) Ævar Arnfjörð Bjarmason
2021-09-23 16:36 ` Junio C Hamano
2021-09-23 16:51 ` Ævar Arnfjörð Bjarmason [this message]
2021-09-23 17:41 ` Jeff King
2021-09-22 0:22 ` ns/batched-fsync (was Re: What's cooking in git.git (Sep 2021, #06; Mon, 20)) Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mto343ze.fsf@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=emilyshaffer@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=me@ttaylorr.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).