git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "hakre via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org,
	Johannes Schindelin <johannes.schindelin@gmx.de>,
	hakre <hanskrentel@yahoo.de>
Subject: Re: [PATCH] ci(check-whitespace): update stale file top comments
Date: Sun, 21 Nov 2021 23:05:30 -0800	[thread overview]
Message-ID: <xmqqilwkk6v9.fsf@gitster.g> (raw)
In-Reply-To: pull.1143.git.git.1637347813367.gitgitgadget@gmail.com

"hakre via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: hakre <hanskrentel@yahoo.de>
>
> Earlier a066a90d (ci(check-whitespace): restrict to the intended
> commits, 2021-07-14) changed the check-whitespace task to stop using a
> shallow clone, and cc003621 (ci(check-whitespace): stop requiring a
> read/write token, 2021-07-14) changed the way how the errors the task
> discovered is signaled back to the user.
>
> They however forgot to update the comment that outlines what is done in
> the task. Correct them.
>
> Signed-off-by: Hans Krentel (hakre) <hanskrentel@yahoo.de>
> ---

I've manually corrected what is queued in my tree, but the name and
address recorded on the in-body From: line should match what is on
the signed-off-by line.  Please make sure I do not have to manually
fix your commits next time.

Thanks.


  reply	other threads:[~2021-11-22  7:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-19 18:50 [PATCH] ci(check-whitespace): update stale file top comments hakre via GitGitGadget
2021-11-22  7:05 ` Junio C Hamano [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-11-13 17:00 hakre via GitGitGadget
2021-11-16 12:26 ` Johannes Schindelin
2021-11-17  6:59   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqilwkk6v9.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=hanskrentel@yahoo.de \
    --cc=johannes.schindelin@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).