From: "hakre via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Johannes Schindelin <johannes.schindelin@gmx.de>,
hakre <hanskrentel@yahoo.de>, hakre <hanskrentel@yahoo.de>
Subject: [PATCH] ci(check-whitespace): update stale file top comments
Date: Sat, 13 Nov 2021 17:00:37 +0000 [thread overview]
Message-ID: <pull.1138.git.git.1636822837587.gitgitgadget@gmail.com> (raw)
From: hakre <hanskrentel@yahoo.de>
Part of these two recent commits
1. a066a90db6 (ci(check-whitespace): restrict to the intended commits,
2021-07-15)
2. cc00362125 (ci(check-whitespace): stop requiring a read/write token,
2021-07-15)
are well written messages that reflect the changes (compare: [1]).
Unfortunately those commits left the description in top file comments
unchanged which are still showing the previous picture.
To better display the current workflow upfront, those comments now
reflect that:
1. full (not shallow) clone to steadily check the intended commits
2. communicated result is the exit status (not a comment in the PR)
[1]: https://git-scm.com/docs/SubmittingPatches#describe-changes
CC: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: hakre <hanskrentel@yahoo.de>
---
ci(check-whitespace): update stale file top comments
Part of these two recent commits
1. a066a90db6 (ci(check-whitespace): restrict to the intended commits,
2021-07-15)
2. cc00362125 (ci(check-whitespace): stop requiring a read/write token,
2021-07-15)
are well written messages that reflect the changes (compare: 1
[https://git-scm.com/docs/SubmittingPatches#describe-changes]).
Unfortunately those commits left the description in top file comments
unchanged which are still showing the previous picture.
To better display the current workflow upfront, those comments now
reflect that:
1. full (not shallow) clone to steadily check the intended commits
2. communicated result is the exit status (not a comment in the PR)
Signed-off-by: hakre hanskrentel@yahoo.de
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1138%2Fhakre%2Fpatch-1-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1138/hakre/patch-1-v1
Pull-Request: https://github.com/git/git/pull/1138
.github/workflows/check-whitespace.yml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/.github/workflows/check-whitespace.yml b/.github/workflows/check-whitespace.yml
index 8c4358d805c..2dce03bc479 100644
--- a/.github/workflows/check-whitespace.yml
+++ b/.github/workflows/check-whitespace.yml
@@ -1,8 +1,8 @@
name: check-whitespace
-# Get the repo with the commits(+1) in the series.
+# Get the repo with all commits to steady catch the series.
# Process `git log --check` output to extract just the check errors.
-# Add a comment to the pull request with the check errors.
+# Give status 2 on check errors.
on:
pull_request:
base-commit: 5fbd2fc5997dfa4d4593a862fe729b1e7a89bcf8
--
gitgitgadget
next reply other threads:[~2021-11-13 17:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-13 17:00 hakre via GitGitGadget [this message]
2021-11-16 12:26 ` [PATCH] ci(check-whitespace): update stale file top comments Johannes Schindelin
2021-11-17 6:59 ` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2021-11-19 18:50 hakre via GitGitGadget
2021-11-22 7:05 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.1138.git.git.1636822837587.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=git@vger.kernel.org \
--cc=hanskrentel@yahoo.de \
--cc=johannes.schindelin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).