From: Junio C Hamano <gitster@pobox.com>
To: "tenglong.tl" <dyroneteng@gmail.com>
Cc: git@vger.kernel.org, avarab@gmail.com, git@jeffhostetler.com,
tenglong.tl@alibaba-inc.com
Subject: Re: [PATCH 2/2] tr2: shows scope unconditionally in addition to key-value pair
Date: Thu, 21 Jul 2022 09:57:10 -0700 [thread overview]
Message-ID: <xmqqh73ajteh.fsf@gitster.g> (raw)
In-Reply-To: <20220721132748.37848-3-tenglong.tl@alibaba-inc.com> (tenglong tl's message of "Thu, 21 Jul 2022 21:27:48 +0800")
"tenglong.tl" <dyroneteng@gmail.com> writes:
> diff --git a/Documentation/technical/api-trace2.txt b/Documentation/technical/api-trace2.txt
> index dcd0429037..229f31ab31 100644
> --- a/Documentation/technical/api-trace2.txt
> +++ b/Documentation/technical/api-trace2.txt
> @@ -717,6 +717,7 @@ The "exec_id" field is a command-unique id and is only useful if the
> {
> "event":"def_param",
> ...
> + scope: <a string that 'git config --show-scope' would return>
> "param":"core.abbrev",
> "value":"7"
> }
Everything in these examples use concrete values and follow the real
syntax (e.g. param is enclosed in double-quotes and so is its value
core.abbrev; even though core.abbrev is not the only param that can
be reported by a def-param event, it is used as a concrete example.
The same story goes for value). The new "scope" thing stands out
like a sore thumb. I think the above should read more like
"event":"def_param",
...
"scope":"global",
"param":"core.abbrev",
"value":"7"
or something. Pick your favourite value for scope.
Other than that, these two patches make quite a lot of sense.
Thanks.
next prev parent reply other threads:[~2022-07-21 16:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-21 13:27 [PATCH 0/2] tr2: shows the scope unconditionally with config tenglong.tl
2022-07-21 13:27 ` [PATCH 1/2] api-trace2.txt: print config key-value pair tenglong.tl
2022-07-21 13:27 ` [PATCH 2/2] tr2: shows scope unconditionally in addition to " tenglong.tl
2022-07-21 16:57 ` Junio C Hamano [this message]
2022-07-22 6:12 ` tenglong.tl
2022-07-22 8:19 ` [PATCH v1 0/2] tr2: shows the scope unconditionally with config tenglong.tl
2022-07-22 8:19 ` [PATCH v1 1/2] api-trace2.txt: print config key-value pair tenglong.tl
2022-07-22 10:59 ` Ævar Arnfjörð Bjarmason
2022-07-25 19:07 ` Junio C Hamano
2022-08-01 12:25 ` tenglong.tl
2022-08-05 22:21 ` Junio C Hamano
2022-08-08 6:16 ` Teng Long
2022-07-22 21:05 ` Junio C Hamano
2022-07-23 6:06 ` tenglong.tl
2022-07-23 17:47 ` Junio C Hamano
2022-07-25 9:18 ` tenglong.tl
2022-07-22 8:19 ` [PATCH v1 2/2] tr2: shows scope unconditionally in addition to " tenglong.tl
2022-08-12 2:56 ` [PATCH v2 0/2] tr2: shows the scope unconditionally with config Teng Long
2022-08-12 2:56 ` [PATCH v2 1/2] api-trace2.txt: print config key-value pair Teng Long
2022-08-12 2:56 ` [PATCH v2 2/2] tr2: shows scope unconditionally in addition to " Teng Long
2022-08-12 21:16 ` Junio C Hamano
2022-08-19 21:18 ` [PATCH v2 0/2] tr2: shows the scope unconditionally with config Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh73ajteh.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=dyroneteng@gmail.com \
--cc=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=tenglong.tl@alibaba-inc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).