From: Junio C Hamano <gitster@pobox.com>
To: "tenglong.tl" <dyroneteng@gmail.com>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
git@jeffhostetler.com, git@vger.kernel.org
Subject: Re: [PATCH v1 1/2] api-trace2.txt: print config key-value pair
Date: Mon, 25 Jul 2022 12:07:09 -0700 [thread overview]
Message-ID: <xmqqczdt3tb6.fsf@gitster.g> (raw)
In-Reply-To: <220722.86fsits91m.gmgdl@evledraar.gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Fri, 22 Jul 2022 12:59:12 +0200")
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> On Fri, Jul 22 2022, tenglong.tl wrote:
> ...
>> +Print Configs::
>> +
>> + Dump "interesting" config values to trace2 log.
>> ++
>> +The environment variable `GIT_TRACE2_CONFIG_PARAMS` and configuration
>> +`trace2.configparams` can be used to output config values which you care
>> +about(see linkgit:git-config[1). For example:
>
> I didn't notice this before, but this is an addition to a long section
> where the examples are ------- delimited, starting with "in this
> example.." usually.
>
> So this "print configs" seems like on odd continuation. Shouldn't this
> copy the template of "Thread Events::" above. I.e. something like (I
> have not tried to asciidoc render this):
>
> Config (def param) Events::
> We can optionally emit configuration events, see
> `trace2.configParams` in linkgit:git-config[1] for how to enable
> it.
> +
> < your example below would follow this>
>
> I.e. re my earlier mention of git-config we it explains
> GIT_TRACE2_CONFIG_PARAMS, so perhaps it suffices to just link to
> linkgit:git-config[1] for that.
>
> Also a nit: trace2.configParams, not trace2.configparams.
These may be worth fixing, regardless of the "adding scope in the
example needs to wait until 2/2" I pointed out separately.
Thanks.
next prev parent reply other threads:[~2022-07-25 19:07 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-21 13:27 [PATCH 0/2] tr2: shows the scope unconditionally with config tenglong.tl
2022-07-21 13:27 ` [PATCH 1/2] api-trace2.txt: print config key-value pair tenglong.tl
2022-07-21 13:27 ` [PATCH 2/2] tr2: shows scope unconditionally in addition to " tenglong.tl
2022-07-21 16:57 ` Junio C Hamano
2022-07-22 6:12 ` tenglong.tl
2022-07-22 8:19 ` [PATCH v1 0/2] tr2: shows the scope unconditionally with config tenglong.tl
2022-07-22 8:19 ` [PATCH v1 1/2] api-trace2.txt: print config key-value pair tenglong.tl
2022-07-22 10:59 ` Ævar Arnfjörð Bjarmason
2022-07-25 19:07 ` Junio C Hamano [this message]
2022-08-01 12:25 ` tenglong.tl
2022-08-05 22:21 ` Junio C Hamano
2022-08-08 6:16 ` Teng Long
2022-07-22 21:05 ` Junio C Hamano
2022-07-23 6:06 ` tenglong.tl
2022-07-23 17:47 ` Junio C Hamano
2022-07-25 9:18 ` tenglong.tl
2022-07-22 8:19 ` [PATCH v1 2/2] tr2: shows scope unconditionally in addition to " tenglong.tl
2022-08-12 2:56 ` [PATCH v2 0/2] tr2: shows the scope unconditionally with config Teng Long
2022-08-12 2:56 ` [PATCH v2 1/2] api-trace2.txt: print config key-value pair Teng Long
2022-08-12 2:56 ` [PATCH v2 2/2] tr2: shows scope unconditionally in addition to " Teng Long
2022-08-12 21:16 ` Junio C Hamano
2022-08-19 21:18 ` [PATCH v2 0/2] tr2: shows the scope unconditionally with config Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqczdt3tb6.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=dyroneteng@gmail.com \
--cc=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).