From: Junio C Hamano <gitster@pobox.com>
To: Li kunyu <kunyu@nfschina.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] builtin: submodule--helper: Add allocation check of module_cb structure objects may be helpful in case of allocation failure
Date: Tue, 22 Nov 2022 13:22:49 +0900 [thread overview]
Message-ID: <xmqqh6yrsjmu.fsf@gitster.g> (raw)
In-Reply-To: <20221122031739.3440-1-kunyu@nfschina.com> (Li kunyu's message of "Tue, 22 Nov 2022 11:17:39 +0800")
Li kunyu <kunyu@nfschina.com> writes:
> The purpose of using temp is unknown, but adding an allocation failure
> report should be helpful.
Yuck. Use of xmalloc() may be more appropriate.
Use of BUG() in a context like this is never the right thing to do.
BUG() is reserved for cases where the condition should NEVER hold
true in a correctly written program, and even for a correctly
written program, malloc() can fail after you allocated too much
memory from the heap.
>
> Signed-off-by: Li kunyu <kunyu@nfschina.com>
> ---
> builtin/submodule--helper.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
> index b63f420ece..2e379623ea 100644
> --- a/builtin/submodule--helper.c
> +++ b/builtin/submodule--helper.c
> @@ -1077,6 +1077,9 @@ static void submodule_summary_callback(struct diff_queue_struct *q,
> if (!S_ISGITLINK(p->one->mode) && !S_ISGITLINK(p->two->mode))
> continue;
> temp = (struct module_cb*)malloc(sizeof(struct module_cb));
> + if (!temp)
> + BUG("The module_cb structure object fails to be allocated and the program may terminate abnormally");
> +
> temp->mod_src = p->one->mode;
> temp->mod_dst = p->two->mode;
> temp->oid_src = p->one->oid;
next prev parent reply other threads:[~2022-11-22 4:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-22 3:17 [PATCH] builtin: submodule--helper: Add allocation check of module_cb structure objects may be helpful in case of allocation failure Li kunyu
2022-11-22 4:22 ` Junio C Hamano [this message]
2022-11-22 8:08 ` Bagas Sanjaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh6yrsjmu.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=kunyu@nfschina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).