git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Li kunyu <kunyu@nfschina.com>
To: git@vger.kernel.org
Cc: Li kunyu <kunyu@nfschina.com>
Subject: [PATCH] builtin: submodule--helper: Add allocation check of module_cb structure objects may be helpful in case of allocation failure
Date: Tue, 22 Nov 2022 11:17:39 +0800	[thread overview]
Message-ID: <20221122031739.3440-1-kunyu@nfschina.com> (raw)

The purpose of using temp is unknown, but adding an allocation failure
report should be helpful.

Signed-off-by: Li kunyu <kunyu@nfschina.com>
---
 builtin/submodule--helper.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
index b63f420ece..2e379623ea 100644
--- a/builtin/submodule--helper.c
+++ b/builtin/submodule--helper.c
@@ -1077,6 +1077,9 @@ static void submodule_summary_callback(struct diff_queue_struct *q,
 		if (!S_ISGITLINK(p->one->mode) && !S_ISGITLINK(p->two->mode))
 			continue;
 		temp = (struct module_cb*)malloc(sizeof(struct module_cb));
+		if (!temp)
+			 BUG("The module_cb structure object fails to be allocated and the program may terminate abnormally");
+
 		temp->mod_src = p->one->mode;
 		temp->mod_dst = p->two->mode;
 		temp->oid_src = p->one->oid;
-- 
2.18.2


             reply	other threads:[~2022-11-22  3:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-22  3:17 Li kunyu [this message]
2022-11-22  4:22 ` [PATCH] builtin: submodule--helper: Add allocation check of module_cb structure objects may be helpful in case of allocation failure Junio C Hamano
2022-11-22  8:08 ` Bagas Sanjaya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221122031739.3440-1-kunyu@nfschina.com \
    --to=kunyu@nfschina.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).