git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Stefan Beller <sbeller@google.com>
Cc: philipoakley@iee.org, jrnieder@gmail.com, git@vger.kernel.org,
	hvoigt@hvoigt.net
Subject: Re: [PATCH] submodule documentation: Reorder introductory paragraphs
Date: Mon, 25 May 2015 15:00:42 -0700	[thread overview]
Message-ID: <xmqqfv6k9v1x.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1432323527-26868-1-git-send-email-sbeller@google.com> (Stefan Beller's message of "Fri, 22 May 2015 12:38:47 -0700")

Stefan Beller <sbeller@google.com> writes:

>  DESCRIPTION
>  -----------
> +This command will inspect, update and manage submodules.
>  
> +Submodules allow you to keep another Git repository in a subdirectory
> +of your repository. The other repository has its own history,...

The first line somehow bothered me, so I took a random sample of
commands I often use:

    git log
       Shows the commit logs.

    git show
       Shows one or more objects (blobs, trees, tags and commits).

    git commit
       Stores the current contents of the index in a new commit along with a
       log message from the user describing the changes.

    git diff
       Show changes between the working tree and the index or a tree, changes
       between the index and a tree, changes between two trees, changes
       between two blob objects, or changes between two files on disk.

    git push
       Updates remote refs using local refs, while sending objects necessary
       to complete the given refs.

I _think_ what bothered me was "This command" (drawing the reaction
"eh, what other command are you going to talk about in the help page
for this command?").  Perhaps

    Inspects, updates and manages submodules.

may match the style of other help pages better.

On the other hand, I probably would not have felt such a strong
"strangeness" if it were described like this:

    This command can help you inspect, update, and manage
    submodules.

I haven't analized it enough to say why it is, but I suspect it has
something to do with (my own) perception that "git submodule" is not
very essential to do any of these things (i.e. .gitmodules is a very
simple text file), but is primarily a helpful wrapper.

The description of "git config", on which I have a similar
perception, seem to match ;-)

    git config
       You can query/set/replace/unset options with this command.

  parent reply	other threads:[~2015-05-25 22:00 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-22 19:38 [PATCH] submodule documentation: Reorder introductory paragraphs Stefan Beller
2015-05-22 21:18 ` Philip Oakley
2015-05-25 22:00 ` Junio C Hamano [this message]
2015-05-26 17:53   ` Stefan Beller
2015-05-26 21:58     ` Heiko Voigt
  -- strict thread matches above, loose matches on Subject: below --
2015-05-20 23:11 Stefan Beller
2015-05-21 13:04 ` Heiko Voigt
2015-05-21 17:24 ` Junio C Hamano
2015-05-21 17:43   ` Stefan Beller
2015-05-21 20:03 ` Philip Oakley
2015-05-21 22:08   ` Stefan Beller
2015-05-22  6:59     ` Philip Oakley
2015-05-22 14:36     ` Junio C Hamano
2015-05-22 17:05       ` Stefan Beller
2015-05-22 17:26         ` Junio C Hamano
2015-05-22 17:35         ` Philip Oakley
2015-05-22 17:51           ` Stefan Beller
2015-05-22 19:47             ` Philip Oakley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqfv6k9v1x.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=hvoigt@hvoigt.net \
    --cc=jrnieder@gmail.com \
    --cc=philipoakley@iee.org \
    --cc=sbeller@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).