From: Junio C Hamano <gitster@pobox.com>
To: David Turner <dturner@twopensource.com>
Cc: git@vger.kernel.org, mhagger@alum.mit.edu
Subject: Re: [PATCH v5 0/7] refs backend preamble
Date: Mon, 29 Jun 2015 12:11:14 -0700 [thread overview]
Message-ID: <xmqqfv5a9vot.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1435600468-21710-1-git-send-email-dturner@twopensource.com> (David Turner's message of "Mon, 29 Jun 2015 13:54:21 -0400")
There might be other issues but from cursory read, at least the
following needs to be split and squashed into patches that introduce
them.
Otherwise, it was a very pleasant read.
Thanks.
Documentation/git-reflog.txt | 4 ++--
builtin/reflog.c | 2 +-
refs.c | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/Documentation/git-reflog.txt b/Documentation/git-reflog.txt
index 7ab2c42..2bf8aa6 100644
--- a/Documentation/git-reflog.txt
+++ b/Documentation/git-reflog.txt
@@ -23,8 +23,8 @@ depending on the subcommand:
[--dry-run] [--verbose] [--all | <refs>...]
'git reflog delete' [--rewrite] [--updateref]
[--dry-run] [--verbose] ref@\{specifier\}...
-'git reflog create <refs>...
-'git reflog exists <ref>
+'git reflog create' <refs>...
+'git reflog exists' <ref>
Reference logs, or "reflogs", record when the tips of branches and
other references were updated in the local repository. Reflogs are
diff --git a/builtin/reflog.c b/builtin/reflog.c
index 1ecbfb6..3080865 100644
--- a/builtin/reflog.c
+++ b/builtin/reflog.c
@@ -742,7 +742,7 @@ static int cmd_reflog_create(int argc, const char **argv, const char *prefix)
static int cmd_reflog_exists(int argc, const char **argv, const char *prefix)
{
- int i, status = 0, start = 0;
+ int i, start = 0;
for (i = 1; i < argc; i++) {
const char *arg = argv[i];
diff --git a/refs.c b/refs.c
index 55235cf..831d31c 100644
--- a/refs.c
+++ b/refs.c
@@ -2911,7 +2911,7 @@ static int rename_ref_available(const char *oldname, const char *newname)
}
static int write_ref_to_lockfile(struct ref_lock *lock,
- const unsigned char *sha1, struct strbuf* err);
+ const unsigned char *sha1, struct strbuf *err);
static int commit_ref_update(struct ref_lock *lock,
const unsigned char *sha1, const char *logmsg,
struct strbuf *err);
--
2.5.0-rc0-169-ge0d9173
prev parent reply other threads:[~2015-06-29 19:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-29 17:54 [PATCH v5 0/7] refs backend preamble David Turner
2015-06-29 17:54 ` [PATCH v5 1/7] refs.c: add err arguments to reflog functions David Turner
2015-06-29 17:54 ` [PATCH v5 2/7] cherry-pick: treat CHERRY_PICK_HEAD and REVERT_HEAD as refs David Turner
2015-06-29 17:54 ` [PATCH v5 3/7] bisect: treat BISECT_HEAD as a ref David Turner
2015-06-29 17:54 ` [PATCH v5 4/7] refs: Break out check for reflog autocreation David Turner
2015-06-29 17:54 ` [PATCH v5 5/7] refs: new public ref function: safe_create_reflog David Turner
2015-06-29 17:54 ` [PATCH v5 6/7] git-reflog: add create and exists functions David Turner
2015-06-29 17:54 ` [PATCH v5 7/7] git-stash: use git-reflog instead of creating files David Turner
2015-06-29 19:11 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfv5a9vot.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=dturner@twopensource.com \
--cc=git@vger.kernel.org \
--cc=mhagger@alum.mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).