From: David Turner <dturner@twopensource.com>
To: git@vger.kernel.org, mhagger@alum.mit.edu
Cc: David Turner <dturner@twopensource.com>
Subject: [PATCH v5 4/7] refs: Break out check for reflog autocreation
Date: Mon, 29 Jun 2015 13:54:25 -0400 [thread overview]
Message-ID: <1435600468-21710-5-git-send-email-dturner@twopensource.com> (raw)
In-Reply-To: <1435600468-21710-1-git-send-email-dturner@twopensource.com>
This is just for clarity.
Signed-off-by: David Turner <dturner@twopensource.com>
---
refs.c | 16 +++++++++++-----
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/refs.c b/refs.c
index b34a54a..dd76721 100644
--- a/refs.c
+++ b/refs.c
@@ -3118,6 +3118,16 @@ static int copy_msg(char *buf, const char *msg)
return cp - buf;
}
+static int should_autocreate_reflog(const char *refname)
+{
+ if (!log_all_ref_updates)
+ return 0;
+ return starts_with(refname, "refs/heads/") ||
+ starts_with(refname, "refs/remotes/") ||
+ starts_with(refname, "refs/notes/") ||
+ !strcmp(refname, "HEAD");
+}
+
/* This function will fill in *err and return -1 on failure */
int log_ref_setup(const char *refname, struct strbuf *sb_logfile, struct strbuf *err)
{
@@ -3128,11 +3138,7 @@ int log_ref_setup(const char *refname, struct strbuf *sb_logfile, struct strbuf
logfile = sb_logfile->buf;
/* make sure the rest of the function can't change "logfile" */
sb_logfile = NULL;
- if (log_all_ref_updates &&
- (starts_with(refname, "refs/heads/") ||
- starts_with(refname, "refs/remotes/") ||
- starts_with(refname, "refs/notes/") ||
- !strcmp(refname, "HEAD"))) {
+ if (should_autocreate_reflog(refname)) {
if (safe_create_leading_directories(logfile) < 0) {
strbuf_addf(err, "unable to create directory for %s. "
"%s", logfile, strerror(errno));
--
2.0.4.315.gad8727a-twtrsrc
next prev parent reply other threads:[~2015-06-29 17:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-29 17:54 [PATCH v5 0/7] refs backend preamble David Turner
2015-06-29 17:54 ` [PATCH v5 1/7] refs.c: add err arguments to reflog functions David Turner
2015-06-29 17:54 ` [PATCH v5 2/7] cherry-pick: treat CHERRY_PICK_HEAD and REVERT_HEAD as refs David Turner
2015-06-29 17:54 ` [PATCH v5 3/7] bisect: treat BISECT_HEAD as a ref David Turner
2015-06-29 17:54 ` David Turner [this message]
2015-06-29 17:54 ` [PATCH v5 5/7] refs: new public ref function: safe_create_reflog David Turner
2015-06-29 17:54 ` [PATCH v5 6/7] git-reflog: add create and exists functions David Turner
2015-06-29 17:54 ` [PATCH v5 7/7] git-stash: use git-reflog instead of creating files David Turner
2015-06-29 19:11 ` [PATCH v5 0/7] refs backend preamble Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435600468-21710-5-git-send-email-dturner@twopensource.com \
--to=dturner@twopensource.com \
--cc=git@vger.kernel.org \
--cc=mhagger@alum.mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).