git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Johannes Sixt <j6t@kdbg.org>, Boxuan Li <liboxuan@connect.hku.hk>,
	git@vger.kernel.org
Subject: Re: [RFC PATCH] userdiff: ship built-in driver config file
Date: Wed, 19 Jun 2019 07:50:00 -0700	[thread overview]
Message-ID: <xmqqfto5r5nr.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20190619034929.GA515@sigill.intra.peff.net> (Jeff King's message of "Tue, 18 Jun 2019 23:49:29 -0400")

Jeff King <peff@peff.net> writes:

> I think it _could_ actually just be part of the system /etc/gitconfig,
> though it is kind of big, and Git has a tendency to parse the config
> more than necessary. I wonder if would add a noticeable slowdown.

Yeah, that was what I was wondering too when somebody made a casual
mention of the "why do we want to pile these settings hardcoded in
the code for each and every language?", which I think led to this
patch.  I was actually imagining that this would be totally outside
the normal config mechanism (there is no strong reason to even share
the syntax, but there is no need to come up with a different syntax,
either), treated like other fixed data files (like *.mo files), and
is read lazily only when diff driver needs to be instantiated.

I also agree with you that changing how multiply-defined variables
are handled with the patch is a no-go, if we are going to share the
parser.

Thanks for a patch and a review.


  parent reply	other threads:[~2019-06-19 14:50 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-17 16:54 [RFC PATCH] userdiff: ship built-in driver config file Boxuan Li
2019-06-18 20:32 ` Johannes Sixt
2019-06-18 20:50   ` Johannes Sixt
2019-06-19  3:49   ` Jeff King
2019-06-19  6:30     ` Johannes Sixt
2019-06-19 15:02       ` Junio C Hamano
2019-06-19 18:39       ` Jeff King
2019-06-20  7:41         ` Johannes Sixt
2019-06-19 14:50     ` Junio C Hamano [this message]
2019-06-19  3:58 ` Jeff King
2019-06-19 15:32   ` LI, BO XUAN
2019-06-19 18:42     ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqfto5r5nr.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=j6t@kdbg.org \
    --cc=liboxuan@connect.hku.hk \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).